Subject: Re: [PATCH net-next v3 2/3] net: phy: air_en8811h: add Airoha AN8811HB support

From: Jakub Kicinski <[email-masked]>
Date: Mon, 26 Jan 2026 19:11:59 -0800

On Mon, 26 Jan 2026 07:57:48 +0100 Bjørn Mork wrote:
> The Airoha AN8811HB is mostly compatible with the EN8811H, adding 10Base-T
> support and reducing power consumption.
> 
> This driver is based on the air_an8811hb v0.0.4 out-of-tree driver
> written by "Lucien.Jheng <[email-masked]>"
> 
> Firmware is available in linux-firmware. The driver has been tested with
> firmware version 25110702

> +static int an8811hb_check_crc(struct phy_device *phydev, u32 set1,
> +			      u32 mon2, u32 mon3)
> +{
> +	u32 pbus_value;
> +	int retry = 25;
> +	int ret;
> +
> +	/* Configure CRC */
> +	ret = air_buckpbus_reg_modify(phydev, set1,
> +				      AN8811HB_CRC_RD_EN,
> +				      AN8811HB_CRC_RD_EN);
> +	if (ret < 0)
> +		return ret;
> +	air_buckpbus_reg_read(phydev, set1, &pbus_value);
> +
> +	do {
> +		mdelay(300);

Did you mean msleep()? mdelay(300) is a lot of spinning.

> +		air_buckpbus_reg_read(phydev, mon2, &pbus_value);
> +
> +		if (pbus_value & AN8811HB_CRC_ST) {
> +			air_buckpbus_reg_read(phydev, mon3, &pbus_value);
> +			phydev_dbg(phydev, "CRC Check %s!\n",
> +				   pbus_value & AN8811HB_CRC_CHECK_PASS ?
> +					"PASS" : "FAIL");

AI code review points out on failure you just print a FAIL and carry on.
Is this because this is what the vendor driver does? Or we know bad CRC
FWs exist in the wild? A comment would be useful here..

> +			return air_buckpbus_reg_modify(phydev, set1,
> +						       AN8811HB_CRC_RD_EN, 0);
> +		}
> +	} while (--retry);
> +

> +static int an8811hb_load_firmware(struct phy_device *phydev)
> +{
> +	struct device *dev = &phydev->mdio.dev;
> +	const struct firmware *fw1, *fw2;
> +	int ret;
> +
> +	ret = request_firmware_direct(&fw1, AN8811HB_MD32_DM, dev);
> +	if (ret < 0)
> +		return ret;
> +
> +	ret = request_firmware_direct(&fw2, AN8811HB_MD32_DSP, dev);
> +	if (ret < 0)
> +		goto an8811hb_load_firmware_rel1;

Please name labels after what they jump to. Per CodingStyle..

> +	ret = air_buckpbus_reg_write(phydev, EN8811H_FW_CTRL_1,
> +				     EN8811H_FW_CTRL_1_START);
> +	if (ret < 0)
> +		goto an8811hb_load_firmware_out;
> +
> +	ret = air_write_buf(phydev, AIR_FW_ADDR_DM,  fw1);
> +	if (ret < 0)
> +		goto an8811hb_load_firmware_out;
> +
> +	ret = an8811hb_check_crc(phydev, AN8811HB_CRC_DM_SET1,
> +				 AN8811HB_CRC_DM_MON2,
> +				 AN8811HB_CRC_DM_MON3);
> +	if (ret < 0)
> +		goto an8811hb_load_firmware_out;
> +
> +	ret = air_write_buf(phydev, AIR_FW_ADDR_DSP, fw2);
> +	if (ret < 0)
> +		goto an8811hb_load_firmware_out;
> +
> +	ret = an8811hb_check_crc(phydev, AN8811HB_CRC_PM_SET1,
> +				 AN8811HB_CRC_PM_MON2,
> +				 AN8811HB_CRC_PM_MON3);
> +	if (ret < 0)
> +		goto an8811hb_load_firmware_out;
> +
> +	ret = en8811h_wait_mcu_ready(phydev);
> +	if (ret < 0)
> +		goto an8811hb_load_firmware_out;

TBH the gotos are a bit hard to read, maybe factor out the logic that
can fail to a separate function? Then we can just capture ret here and
fall thru; and the helper itself can return ret; directly.
-- 
pw-bot: cr