From: Jakub Kicinski <kuba@kernel•org>
To: "Maciej W. Rozycki" <macro@orcam•me.uk>
Cc: "Ethan Nelson-Moore" <enelsonmoore@gmail•com>,
netdev@vger•kernel.org, linux-doc@vger•kernel.org,
linux-pci@vger•kernel.org, linux-mips@vger•kernel.org,
linux-s390@vger•kernel.org, "Jonathan Corbet" <corbet@lwn•net>,
"Linas Vepstas" <linasvepstas@gmail•com>,
"Mahesh J Salgaonkar" <mahesh@linux•ibm.com>,
"Oliver O'Halloran" <oohall@gmail•com>,
"Bjorn Helgaas" <bhelgaas@google•com>,
"David S. Miller" <davem@davemloft•net>,
"Eric Dumazet" <edumazet@google•com>,
"Paolo Abeni" <pabeni@redhat•com>,
"Simon Horman" <horms@kernel•org>,
"Thomas Bogendoerfer" <tsbogend@alpha•franken.de>,
"Madhavan Srinivasan" <maddy@linux•ibm.com>,
"Michael Ellerman" <mpe@ellerman•id.au>,
"Nicholas Piggin" <npiggin@gmail•com>,
"Christophe Leroy (CS GROUP)" <chleroy@kernel•org>,
"Heiko Carstens" <hca@linux•ibm.com>,
"Vasily Gorbik" <gor@linux•ibm.com>,
"Alexander Gordeev" <agordeev@linux•ibm.com>,
"Christian Borntraeger" <borntraeger@linux•ibm.com>,
"Sven Schnelle" <svens@linux•ibm.com>,
"Andrew Lunn" <andrew+netdev@lunn•ch>,
"Andrew Morton" <akpm@linux-foundation•org>,
"Martin Kepplinger-Novaković" <martink@posteo•de>,
"Pavel Machek" <pavel@ucw•cz>,
"MD Danish Anwar" <danishanwar@ti•com>,
"Mengyuan Lou" <mengyuanlou@net-swift•com>,
"Pablo Neira Ayuso" <pablo@netfilter•org>,
"Takashi Iwai" <tiwai@suse•de>,
"Huacai Chen" <chenhuacai@kernel•org>,
"Theodore Ts'o" <tytso@mit•edu>,
"Eric Biggers" <ebiggers@google•com>,
"Madadi Vineeth Reddy" <vineethr@linux•ibm.com>,
"Shrikanth Hegde" <sshegde@linux•ibm.com>,
"Geert Uytterhoeven" <geert@linux-m68k•org>,
"Ard Biesheuvel" <ardb@kernel•org>,
"Martin K. Petersen" <martin.petersen@oracle•com>,
"Frederic Barrat" <fbarrat@linux•ibm.com>,
"Andrew Donnellan" <ajd@linux•ibm.com>,
"Herbert Xu" <herbert@gondor•apana.org.au>,
"Konstantin Shkolnyy" <kshk@linux•ibm.com>,
"Vadim Fedorenko" <vadim.fedorenko@linux•dev>,
"Lorenzo Bianconi" <lorenzo@kernel•org>,
"Lukas Bulwahn" <lukas.bulwahn@redhat•com>,
"Dong Yibo" <dong100@mucse•com>,
"Heiner Kallweit" <hkallweit1@gmail•com>,
"Thomas Gleixner" <tglx@kernel•org>,
"Ingo Molnar" <mingo@kernel•org>,
"Lukas Wunner" <lukas@wunner•de>,
"Giovanni Cabiddu" <giovanni.cabiddu@intel•com>
Subject: Re: [PATCH net-next v2] net: ethernet: neterion: s2io: remove unused driver
Date: Tue, 27 Jan 2026 15:56:07 -0800 [thread overview]
Message-ID: <20260127155607.3f80ec99@kernel.org> (raw)
In-Reply-To: <alpine.DEB.2.21.2601270110590.40317@angie.orcam.me.uk>
On Tue, 27 Jan 2026 01:19:34 +0000 (GMT) Maciej W. Rozycki wrote:
> > highly unlikely that this driver is still being used. Remove the
> > driver, and move the former maintainer to the CREDITS file (restoring
> > credit for the vxge driver, which was removed in commit f05643a0f60b
> > ("eth: remove neterion/vxge").
>
> How do you know it's not used?
Hard to prove a negative and whatnot.
We deleted the vxge which I think(?) was for a newer version of this HW
3+ years ago and nobody complained.
> What's the gain from removing a driver unless say it's broken and
> does not build?
People keep sending cleanups and fixes for these old drivers.
It takes time to review that stuff.
next prev parent reply other threads:[~2026-01-27 23:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-26 3:08 [PATCH net-next v2] net: ethernet: neterion: s2io: remove unused driver Ethan Nelson-Moore
2026-01-27 1:19 ` Maciej W. Rozycki
2026-01-27 23:56 ` Jakub Kicinski [this message]
2026-01-29 3:55 ` Ethan Nelson-Moore
2026-01-29 13:44 ` Maciej W. Rozycki
2026-01-29 13:42 ` Maciej W. Rozycki
2026-01-29 5:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260127155607.3f80ec99@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=agordeev@linux$(echo .)ibm.com \
--cc=ajd@linux$(echo .)ibm.com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=ardb@kernel$(echo .)org \
--cc=bhelgaas@google$(echo .)com \
--cc=borntraeger@linux$(echo .)ibm.com \
--cc=chenhuacai@kernel$(echo .)org \
--cc=chleroy@kernel$(echo .)org \
--cc=corbet@lwn$(echo .)net \
--cc=danishanwar@ti$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=dong100@mucse$(echo .)com \
--cc=ebiggers@google$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=enelsonmoore@gmail$(echo .)com \
--cc=fbarrat@linux$(echo .)ibm.com \
--cc=geert@linux-m68k$(echo .)org \
--cc=giovanni.cabiddu@intel$(echo .)com \
--cc=gor@linux$(echo .)ibm.com \
--cc=hca@linux$(echo .)ibm.com \
--cc=herbert@gondor$(echo .)apana.org.au \
--cc=hkallweit1@gmail$(echo .)com \
--cc=horms@kernel$(echo .)org \
--cc=kshk@linux$(echo .)ibm.com \
--cc=linasvepstas@gmail$(echo .)com \
--cc=linux-doc@vger$(echo .)kernel.org \
--cc=linux-mips@vger$(echo .)kernel.org \
--cc=linux-pci@vger$(echo .)kernel.org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=lorenzo@kernel$(echo .)org \
--cc=lukas.bulwahn@redhat$(echo .)com \
--cc=lukas@wunner$(echo .)de \
--cc=macro@orcam$(echo .)me.uk \
--cc=maddy@linux$(echo .)ibm.com \
--cc=mahesh@linux$(echo .)ibm.com \
--cc=martin.petersen@oracle$(echo .)com \
--cc=martink@posteo$(echo .)de \
--cc=mengyuanlou@net-swift$(echo .)com \
--cc=mingo@kernel$(echo .)org \
--cc=mpe@ellerman$(echo .)id.au \
--cc=netdev@vger$(echo .)kernel.org \
--cc=npiggin@gmail$(echo .)com \
--cc=oohall@gmail$(echo .)com \
--cc=pabeni@redhat$(echo .)com \
--cc=pablo@netfilter$(echo .)org \
--cc=pavel@ucw$(echo .)cz \
--cc=sshegde@linux$(echo .)ibm.com \
--cc=svens@linux$(echo .)ibm.com \
--cc=tglx@kernel$(echo .)org \
--cc=tiwai@suse$(echo .)de \
--cc=tsbogend@alpha$(echo .)franken.de \
--cc=tytso@mit$(echo .)edu \
--cc=vadim.fedorenko@linux$(echo .)dev \
--cc=vineethr@linux$(echo .)ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox