Subject: Re: [PATCH net-next v2] net: bridge: use sysfs_emit instead of sprintf

From: Ido Schimmel <[email-masked]>
Date: Mon, 2 Feb 2026 19:44:09 +0200

On Mon, Feb 02, 2026 at 07:07:12AM +0000, David Corvaglia wrote:
> @@ -677,9 +677,8 @@ static ssize_t multicast_query_response_interval_show(
>  	struct device *d, struct device_attribute *attr, char *buf)
>  {
>  	struct net_bridge *br = to_bridge(d);
> -	return sprintf(
> -		buf, "%lu\n",
> -		jiffies_to_clock_t(br->multicast_ctx.multicast_query_response_interval));
> +	return sysfs_emit(buf, "%lu\n",
> +		          jiffies_to_clock_t(br->multicast_ctx.multicast_query_response_interval));
>  }

I get:

$ b4 shazam -k [email-masked]
[...]
    ● checkpatch.pl: 392: ERROR: code indent should use tabs where possible
[...]

$ scripts/checkpatch.pl -g HEAD
ERROR: code indent should use tabs where possible
#332: FILE: net/bridge/br_sysfs_br.c:681:
+^I^I          jiffies_to_clock_t(br->multicast_ctx.multicast_query_response_interval));$

total: 1 errors, 0 warnings, 0 checks, 495 lines checked