Subject: Re: [PATCH net-next 3/3] tcp: make tcp_v{4,6}_send_check() static

From: Jakub Kicinski <[email-masked]>
Date: Tue, 3 Feb 2026 09:26:36 -0800

On Tue,  3 Feb 2026 14:40:53 +0000 Eric Dumazet wrote:
> tcp_v{4,6}_send_check() are only called from tcp_output.c
> and should be made static so that the compiler does not need
> to put an out of line copy of them.
> 
> Remove (struct inet_connection_sock_af_ops) send_check field
> and use instead @net_header_len.
> 
> Move @net_header_len close to @queue_xmit for data locality
> as both are used in TCP tx fast path.

Seeing this in allmodconfig:

net/ipv4/tcp_output.c:1482:13: warning: unused function 'tcp_v4_send_check' [-Wunused-function]
 1482 | static void tcp_v4_send_check(struct sock *sk, struct sk_buff *skb)
      |             ^~~~~~~~~~~~~~~~~
-- 
pw-bot: cr