Subject: Re: [PATCH net-next v2 02/14] net: bridge: mcast: track active state, adding tests

From: Jakub Kicinski <[email-masked]>
Date: Fri, 6 Feb 2026 20:58:27 -0800

On Fri,  6 Feb 2026 03:52:08 +0100 Linus Lüssing wrote:
> Before making any significant changes to the internals of the Linux
> bridge add some tests regarding the multicast activity. This is
> also to verify that we have the semantics of the new
> *_MCAST_ACTIVE_{V4,V6} netlink attributes as expected.

shellcheck has a bunch of complains here, including these two warnings:

+In bridge_mdb_active.sh line 124:
+	if [ $ret -eq 0 -a $state -eq 0 ] || [ $ret -ne 0 -a $state -eq 1 ]; then
+             ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
+                        ^-- SC2166 (warning): Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.
+                                                          ^-- SC2166 (warning): Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.

>  .../net/forwarding/bridge_mdb_active.sh       | 682 ++++++++++++++++++

Is there a reason this test is not included in the makefile?
-- 
pw-bot: cr