Subject: Re: [PATCH net] bnge: Fix typo

From: Jakub Kicinski <[email-masked]>
Date: Tue, 17 Feb 2026 14:40:34 -0800

On Tue, 17 Feb 2026 23:13:47 +0530 Vikas Gupta wrote:
> On Tue, Feb 17, 2026 at 9:26 PM Simon Horman <[email-masked]> wrote:
> > On Mon, Feb 16, 2026 at 07:32:35PM +0530, Vikas Gupta wrote:  
> > > Fix the HWRM command type and use the appropriate command to reserve
> > > the resources.
> > >
> > > Fixes: 627c67f038d2 ("bng_en: Add resource management support")
> > > Signed-off-by: Vikas Gupta <[email-masked]>
> > > Reviewed-by: Bhargava Chenna Marreddy <[email-masked]>  
> >
> > I think this patch could do with a little more explanation.
> > It's not clear to me, at least: what the difference is between
> > HWRM_FUNC_QCFG and HWRM_FUNC_CFG; and why only one of
> > the instances added by the cited patch needs updating.  
> 
> HWRM_FUNC_CFG is used to reserve resources, whereas HWRM_FUNC_QCFG is intended
> for querying resource information from the firmware.
> Since __bnge_hwrm_reserve_pf_rings() reserves resources for a specific
> PF, the command type
> should be HWRM_FUNC_CFG.
> However, HWRM_FUNC_QCFG was mistakenly used instead.
> Does it clarify?

Yes, please add this to the commit message.

Also please improve the subject. Something like (just a guess):

	bnge: fix reserving resources from FW

"fix typo" sounds like you're fixing spelling in a comment, it's not at
all informative :/