From: Jakub Kicinski <kuba@kernel•org>
To: Martin KaFai Lau <martin.lau@linux•dev>
Cc: Feng Yang <yangfeng59949@163•com>,
andrii@kernel•org, ast@kernel•org, bpf@vger•kernel.org,
daniel@iogearbox•net, davem@davemloft•net, edumazet@google•com,
horms@kernel•org, linux-kernel@vger•kernel.org,
netdev@vger•kernel.org, pabeni@redhat•com
Subject: Re: [PATCH v5] bpf: test_run: Fix the null pointer dereference issue in bpf_lwt_xmit_push_encap
Date: Tue, 17 Feb 2026 15:39:24 -0800 [thread overview]
Message-ID: <20260217153924.33391554@kernel.org> (raw)
In-Reply-To: <1bc24867-edde-408e-ac1b-2ca2a41622b5@linux.dev>
On Tue, 17 Feb 2026 15:26:33 -0800 Martin KaFai Lau wrote:
> > Having fastpath checks for test harness really feels like duct tape
>
> Adding route lookup on ip[v6]_hdr does not work well either and is a
> larger duct tape on the test_run_skb side.
Well, maybe to clarify, the responsibility of the test harness is to
generate valid inputs. Whether it's hard or not to address this issue
in test_run_skb is a less fundamental than whether it is the correct
place to address it.
> An option is to always set skb to 'some' dst (loopback or
> ipv6.fib6_null_entry) on all is_lwt cases without doing the lookup. It
> is only to get it going. It is a duct tape also imo but maybe a middle
> ground.
Sounds reasonable to me, FWIW.
next prev parent reply other threads:[~2026-02-17 23:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-10 9:06 [PATCH v5] bpf: test_run: Fix the null pointer dereference issue in bpf_lwt_xmit_push_encap Feng Yang
2026-02-10 18:34 ` kernel test robot
2026-02-10 19:08 ` kernel test robot
2026-02-10 19:10 ` Martin KaFai Lau
2026-02-11 7:52 ` Feng Yang
2026-02-17 18:08 ` Martin KaFai Lau
2026-02-17 22:08 ` Jakub Kicinski
2026-02-17 23:26 ` Martin KaFai Lau
2026-02-17 23:39 ` Jakub Kicinski [this message]
2026-02-10 20:26 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260217153924.33391554@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=andrii@kernel$(echo .)org \
--cc=ast@kernel$(echo .)org \
--cc=bpf@vger$(echo .)kernel.org \
--cc=daniel@iogearbox$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=horms@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=martin.lau@linux$(echo .)dev \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=yangfeng59949@163$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox