Subject: Re: [PATCH net-next 2/7] bng_en: query PHY capabilities and report link status

From: Jakub Kicinski <[email-masked]>
Date: Tue, 24 Feb 2026 18:35:28 -0800

On Mon, 23 Feb 2026 22:06:36 +0530 Bhargava Marreddy wrote:
> +	/* To protect link related settings during link changes and
> +	 * ethtool settings changes.
> +	 */
> +	struct mutex		link_lock;
> +	struct bnge_link_info	link_info;

Why does link deserve its own lock? Are the operations slow?

bnxt was written before the netdev instance lock existed, if you're
just trying to avoid taking rtnl_lock the instance lock would do.