From: Byungchul Park <byungchul@sk•com>
To: netdev@vger•kernel.org, kuba@kernel•org
Cc: linux-kernel@vger•kernel.org, kernel_team@skhynix•com,
harry.yoo@oracle•com, david@redhat•com, willy@infradead•org,
toke@redhat•com, asml.silence@gmail•com, almasrymina@google•com,
anthony.l.nguyen@intel•com, przemyslaw.kitszel@intel•com,
andrew+netdev@lunn•ch, davem@davemloft•net, edumazet@google•com,
pabeni@redhat•com, intel-wired-lan@lists•osuosl.org
Subject: Re: [RESEND PATCH] ice: access @pp through netmem_desc instead of page
Date: Thu, 26 Feb 2026 10:08:11 +0900 [thread overview]
Message-ID: <20260226010811.GA16777@system.software.com> (raw)
In-Reply-To: <20260224053546.62757-1-byungchul@sk.com>
On Tue, Feb 24, 2026 at 02:35:46PM +0900, Byungchul Park wrote:
> To eliminate the use of struct page in page pool, the page pool users
> should use netmem descriptor and APIs instead.
>
> Make ice driver access @pp through netmem_desc instead of page.
Hi Tony and Przemek,
Is there something that I'm missing or something wrong with this? Your
feedback would be appreciated. Thanks!
Byungchul
> Signed-off-by: Byungchul Park <byungchul@sk•com>
> ---
> drivers/net/ethernet/intel/ice/ice_ethtool.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/intel/ice/ice_ethtool.c b/drivers/net/ethernet/intel/ice/ice_ethtool.c
> index c6bc29cfb8e6..c16e54dbe75b 100644
> --- a/drivers/net/ethernet/intel/ice/ice_ethtool.c
> +++ b/drivers/net/ethernet/intel/ice/ice_ethtool.c
> @@ -1251,7 +1251,7 @@ static int ice_lbtest_receive_frames(struct ice_rx_ring *rx_ring)
> rx_buf = &rx_ring->rx_fqes[i];
> page = __netmem_to_page(rx_buf->netmem);
> received_buf = page_address(page) + rx_buf->offset +
> - page->pp->p.offset;
> + pp_page_to_nmdesc(page)->pp->p.offset;
>
> if (ice_lbtest_check_frame(received_buf))
> valid_frames++;
> --
> 2.17.1
next prev parent reply other threads:[~2026-02-26 1:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-24 5:35 [RESEND PATCH] ice: access @pp through netmem_desc instead of page Byungchul Park
2026-02-26 1:08 ` Byungchul Park [this message]
2026-02-26 18:13 ` Tony Nguyen
2026-03-31 8:11 ` Byungchul Park
2026-03-31 17:08 ` Tony Nguyen
2026-04-01 3:53 ` [Intel-wired-lan] " Nowlin, Alexander
2026-04-01 4:44 ` Rinitha, SX
2026-04-01 7:24 ` David Hildenbrand (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260226010811.GA16777@system.software.com \
--to=byungchul@sk$(echo .)com \
--cc=almasrymina@google$(echo .)com \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=anthony.l.nguyen@intel$(echo .)com \
--cc=asml.silence@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=david@redhat$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=harry.yoo@oracle$(echo .)com \
--cc=intel-wired-lan@lists$(echo .)osuosl.org \
--cc=kernel_team@skhynix$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=przemyslaw.kitszel@intel$(echo .)com \
--cc=toke@redhat$(echo .)com \
--cc=willy@infradead$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox