From: Jakub Kicinski <kuba@kernel•org>
To: "Bastien Curutchet (Schneider Electric)" <bastien.curutchet@bootlin•com>
Cc: "Woojung Huh" <woojung.huh@microchip•com>,
UNGLinuxDriver@microchip•com, "Andrew Lunn" <andrew@lunn•ch>,
"Vladimir Oltean" <olteanv@gmail•com>,
"David S. Miller" <davem@davemloft•net>,
"Eric Dumazet" <edumazet@google•com>,
"Paolo Abeni" <pabeni@redhat•com>,
"Richard Cochran" <richardcochran@gmail•com>,
"Simon Horman" <horms@kernel•org>,
"Pascal Eberhard" <pascal.eberhard@se•com>,
"Miquèl Raynal" <miquel.raynal@bootlin•com>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin•com>,
netdev@vger•kernel.org, linux-kernel@vger•kernel.org,
"Maxime Chevallier" <maxime.chevallier@bootlin•com>
Subject: Re: [PATCH net-next v5 1/9] net: dsa: microchip: Add support for KSZ8463 global irq
Date: Sat, 28 Feb 2026 14:16:30 -0800 [thread overview]
Message-ID: <20260228141630.15b4292d@kernel.org> (raw)
In-Reply-To: <20260226-ksz8463-ptp-v5-1-1bc24fb9627d@bootlin.com>
On Thu, 26 Feb 2026 17:41:48 +0100 Bastien Curutchet (Schneider
Electric) wrote:
> /* Read interrupt status register */
> - ret = ksz_read8(dev, kirq->reg_status, &data);
> + ret = ksz_read16(dev, kirq->reg_status, &data);
> if (ret)
> goto out;
I think you promised to extend this comment to indicate that the
over-read is safe?
https://lore.kernel.org/netdev/c9cb204b-e079-4f5b-b670-dcce14101390@bootlin.com/
Also could you go thru the series and check for cases where the lines
are unnecessarily long? In netdev we still prefer 80 chars.
Not a hard requirement, of course, sometimes wrapping hurts readability.
But plenty of examples in here of this which could be trivially wrapped:
WARNING: line length of 96 exceeds 80 columns
#166: FILE: drivers/net/dsa/microchip/ksz_ptp.c:1138:
+static int ksz8463_ptp_port_irq_setup(struct ksz_irq *ptpirq, struct ksz_port *port, int hw_irq)
WARNING: line length of 82 exceeds 80 columns
#207: FILE: drivers/net/dsa/microchip/ksz_ptp.c:1179:
+ ptpirq->irq_num = irq_find_mapping(dev->girq.domain, KSZ8463_SRC_PTP_INT);
WARNING: line length of 86 exceeds 80 columns
#218: FILE: drivers/net/dsa/microchip/ksz_ptp.c:1190:
+ ptpirq->domain = irq_domain_create_linear(dev_fwnode(dev->dev), ptpirq->nirqs,
WARNING: line length of 83 exceeds 80 columns
#219: FILE: drivers/net/dsa/microchip/ksz_ptp.c:1191:
+ &ksz_ptp_irq_domain_ops, ptpirq);
... etc..
--
pw-bot: cr
next prev parent reply other threads:[~2026-02-28 22:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-26 16:41 [PATCH net-next v5 0/9] net: dsa: microchip: Add PTP support for the KSZ8463 Bastien Curutchet (Schneider Electric)
2026-02-26 16:41 ` [PATCH net-next v5 1/9] net: dsa: microchip: Add support for KSZ8463 global irq Bastien Curutchet (Schneider Electric)
2026-02-28 22:16 ` Jakub Kicinski [this message]
2026-03-04 8:13 ` Bastien Curutchet
2026-02-26 16:41 ` [PATCH net-next v5 2/9] net: dsa: microchip: Decorrelate IRQ domain from port Bastien Curutchet (Schneider Electric)
2026-02-26 16:41 ` [PATCH net-next v5 3/9] net: dsa: microchip: Decorrelate msg_irq index from IRQ bit offset Bastien Curutchet (Schneider Electric)
2026-02-26 16:41 ` [PATCH net-next v5 4/9] net: dsa: microchip: Add support for KSZ8463's PTP interrupts Bastien Curutchet (Schneider Electric)
2026-02-26 16:41 ` [PATCH net-next v5 5/9] net: dsa: tag_ksz: Share code for KSZ8795 and KSZ9893 xmit operations Bastien Curutchet (Schneider Electric)
2026-02-26 16:41 ` [PATCH net-next v5 6/9] net: dsa: microchip: Add KSZ8463 tail tag handling Bastien Curutchet (Schneider Electric)
2026-02-26 16:41 ` [PATCH net-next v5 7/9] net: dsa: microchip: Explicitly enable detection of L2 PTP frames Bastien Curutchet (Schneider Electric)
2026-02-26 16:41 ` [PATCH net-next v5 8/9] net: dsa: microchip: Adapt port offset for KSZ8463's PTP register Bastien Curutchet (Schneider Electric)
2026-02-26 16:41 ` [PATCH net-next v5 9/9] net: dsa: microchip: Add two-step PTP support for KSZ8463 Bastien Curutchet (Schneider Electric)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260228141630.15b4292d@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=UNGLinuxDriver@microchip$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=bastien.curutchet@bootlin$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=horms@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=maxime.chevallier@bootlin$(echo .)com \
--cc=miquel.raynal@bootlin$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=olteanv@gmail$(echo .)com \
--cc=pabeni@redhat$(echo .)com \
--cc=pascal.eberhard@se$(echo .)com \
--cc=richardcochran@gmail$(echo .)com \
--cc=thomas.petazzoni@bootlin$(echo .)com \
--cc=woojung.huh@microchip$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox