Subject: Re: [PATCH net-next v2 04/10] devlink: allow to use devlink index as a command handle

From: Jakub Kicinski <[email-masked]>
Date: Sat, 28 Feb 2026 14:48:46 -0800

On Wed, 25 Feb 2026 14:34:16 +0100 Jiri Pirko wrote:
> +	if (attrs[DEVLINK_ATTR_INDEX]) {
> +		index = nla_get_uint(attrs[DEVLINK_ATTR_INDEX]);
> +		devlink = devlinks_xa_lookup_get(net, index);
> +		if (!devlink)
> +			return ERR_PTR(-ENODEV);
> +		goto found;
> +	}
> +
>  	if (!attrs[DEVLINK_ATTR_BUS_NAME] || !attrs[DEVLINK_ATTR_DEV_NAME])
>  		return ERR_PTR(-EINVAL);

If both INDEX and BUS_NAME + DEV_NAME are provided we should check
that they point to the same device? Or reject user space passing both?