Subject: Re: [PATCH net v3] ipv4: bump rt_genid when a relevant devconf value changes through netlink

From: Jakub Kicinski <[email-masked]>
Date: Tue, 3 Mar 2026 18:38:43 -0800

On Mon,  2 Mar 2026 14:08:57 +0100 Fernando Fernandez Mancera wrote:
> +			switch (nla_type(a)) {
> +			case IPV4_DEVCONF_FORWARDING:
> +				if (nla_get_u32(a))
> +					netif_disable_lro(dev);

why not dev_disable_lro()??

> +				fallthrough;
> +			case IPV4_DEVCONF_NOXFRM:
> +			case IPV4_DEVCONF_NOPOLICY:
> +			case IPV4_DEVCONF_PROMOTE_SECONDARIES:
> +			case IPV4_DEVCONF_ROUTE_LOCALNET:
> +			case IPV4_DEVCONF_DROP_UNICAST_IN_L2_MULTICAST:
> +				flush_cache = true;
> +				break;
> +			default:
> +				break;
> +			}
> +		}
> +		if (flush_cache)
> +			rt_cache_flush(net);
>  	}

Looking closer at this I'm struggling to connect this to
devinet_conf_proc(). The attrs you're snooping here are completely different!?
Logic for when rt_cache_flush() happens is different.

inet_netconf_notify_devconf() is missing even after the patch.
-- 
pw-bot: cr