Subject: Re: [PATCH net-next v2 2/3] bnxt_en: Resize RSS contexts on channel count change

From: Jakub Kicinski <[email-masked]>
Date: Thu, 5 Mar 2026 19:05:18 -0800

On Wed,  4 Mar 2026 14:18:52 +0100 Björn Töpel wrote:
> +		if (netif_is_rxfh_configured(dev) &&
> +		    ethtool_rxfh_can_resize(bp->rss_indir_tbl,
> +					    old_tbl_size, new_tbl_size)) {

Doesn't this read a little odd? Shouldn't ethtool_rxfh_can_resize()
return true when ... we can resize? You end up ignoring the real rc
here, and it can only ever be -EINVAL.

> +			netdev_warn(dev, "RSS table resize not possible\n");
> +			return -EINVAL;
> +		}