Subject: Re: [PATCH net-next 5/9] selftests: ovpn: add notification parsing and matching

From: Jakub Kicinski <[email-masked]>
Date: Fri, 6 Mar 2026 13:01:30 -0800

On Thu,  5 Mar 2026 00:06:23 +0100 Antonio Quartulli wrote:
> +def check_requirements(requirements_path):
> +    """Return dependency issues from requirements_path, or an empty list."""
> +    issues = []
> +    with open(requirements_path, encoding="utf-8") as f:

Semi-jokingly let me also mention that you do all this requirements
checking here, all the dependencies seem to have been installed on
netdev CI already. One thing for which you don't check is ngrep,
and that was not installed.

IMO the requirements checking is a waste of effort, things always
slip thru. But unless you have a strong reason to use ngrep maybe
switch to a more standard tool?