Subject: Re: [PATCH net] page_pool: store detach_time as ktime_t to avoid false-negatives

From: Jakub Kicinski <[email-masked]>
Date: Sun, 8 Mar 2026 09:21:35 -0700

On Sun, 8 Mar 2026 01:10:55 +0100 Eric Dumazet wrote:
> > --- a/net/core/page_pool_user.c
> > +++ b/net/core/page_pool_user.c
> > @@ -245,7 +245,7 @@ page_pool_nl_fill(struct sk_buff *rsp, const struct page_pool *pool,
> >                 goto err_cancel;  
> 
> It is a bit unclear if we always hold page_pools_lock at this point.
> 
> If not, a READ_ONCE(pool->user.detach_time) here would be needed,
> and a corresponding WRITE_ONCE() in  page_pool_detached()

There's a bit of convoluted wrapping to share the code between page
pool access and access to stats, but AFAICT page_pools_lock should 
be consistently held by readers and writers.