From: Jakub Kicinski <kuba@kernel•org>
To: Bhargava Marreddy <bhargava.marreddy@broadcom•com>
Cc: davem@davemloft•net, edumazet@google•com, pabeni@redhat•com,
andrew+netdev@lunn•ch, horms@kernel•org, netdev@vger•kernel.org,
linux-kernel@vger•kernel.org, michael.chan@broadcom•com,
pavan.chebbi@broadcom•com, vsrama-krishna.nemani@broadcom•com,
vikas.gupta@broadcom•com
Subject: Re: [PATCH net-next v6 10/10] bng_en: add support for ethtool -S stats display
Date: Thu, 12 Mar 2026 19:22:51 -0700 [thread overview]
Message-ID: <20260312192251.61243873@kernel.org> (raw)
In-Reply-To: <20260310144044.21672-11-bhargava.marreddy@broadcom.com>
On Tue, 10 Mar 2026 20:10:44 +0530 Bhargava Marreddy wrote:
> Implement the legacy ethtool statistics interface (.get_sset_count,
> .get_strings, and .get_ethtool_stats) to provide per-queue and
> port-level visibility.
>
> A. Exclusions:
> To comply with the "no duplication" policy, excluded all stats already
> covered by rtnl_link_stats64.
> For ex:
> 1. tx_err
> 2. tx_fifo_underruns
> 3. tx_total_collisions
>
> B. Retained Stats Analysis:
> Retained the counters which provide unique per-queue granularity or
> represent different hardware events:
>
> 1. rxqN_errors
> 2. txqN_errors
>
> These provide per-ring visibility for debugging.
> While they look similar to ndo_get_stats64's [rx/tx]_errors counters,
> they map to different hardware sources:
> For ex:
> - ethtool rxqN_errors: ctx_hw_stats->rx_error_pkts (per-ring)
> - ndo_get_stats64 rx_errors: (rx_port_stats->rx_false_carrier_frames +
> rx_jbr_frames) (per-port)
Still a lot of stuff here that has standard APIs. Here is random 4:
- oom_discards
- rx_total_frames
- link_down_event
- rx_fec_corrected_blocks
Please explain what the per-ring errors and discards are exactly.
prev parent reply other threads:[~2026-03-13 2:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-10 14:40 [PATCH net-next v6 00/10] bng_en: add link management and statistics support Bhargava Marreddy
2026-03-10 14:40 ` [PATCH net-next v6 01/10] bng_en: add per-PF workqueue, timer, and slow-path task Bhargava Marreddy
2026-03-10 14:40 ` [PATCH net-next v6 02/10] bng_en: query PHY capabilities and report link status Bhargava Marreddy
2026-03-11 15:44 ` ALOK TIWARI
2026-03-13 2:18 ` [net-next,v6,02/10] " Jakub Kicinski
2026-03-10 14:40 ` [PATCH net-next v6 03/10] bng_en: add ethtool link settings, get_link, and nway_reset Bhargava Marreddy
2026-03-10 14:40 ` [PATCH net-next v6 04/10] bng_en: implement ethtool pauseparam operations Bhargava Marreddy
2026-03-10 14:40 ` [PATCH net-next v6 05/10] bng_en: add support for link async events Bhargava Marreddy
2026-03-10 14:40 ` [PATCH net-next v6 06/10] bng_en: add HW stats infra and structured ethtool ops Bhargava Marreddy
2026-03-18 7:47 ` Dan Carpenter
2026-03-10 14:40 ` [PATCH net-next v6 07/10] bng_en: periodically fetch and accumulate hardware statistics Bhargava Marreddy
2026-03-10 14:40 ` [PATCH net-next v6 08/10] bng_en: implement ndo_get_stats64 Bhargava Marreddy
2026-03-10 14:40 ` [PATCH net-next v6 09/10] bng_en: implement netdev_stat_ops Bhargava Marreddy
2026-03-10 14:40 ` [PATCH net-next v6 10/10] bng_en: add support for ethtool -S stats display Bhargava Marreddy
2026-03-12 7:01 ` ALOK TIWARI
2026-03-13 2:22 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260312192251.61243873@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=bhargava.marreddy@broadcom$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=horms@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=michael.chan@broadcom$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=pavan.chebbi@broadcom$(echo .)com \
--cc=vikas.gupta@broadcom$(echo .)com \
--cc=vsrama-krishna.nemani@broadcom$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox