Subject: Re: [PATCH net v2] net: airoha: Remove airoha_dev_stop() in airoha_remove()

From: Simon Horman <[email-masked]>
Date: Fri, 13 Mar 2026 14:31:46 +0000

On Fri, Mar 13, 2026 at 12:27:00PM +0100, Lorenzo Bianconi wrote:
> Do not run airoha_dev_stop routine explicitly in airoha_remove()
> since ndo_stop() callback is already executed by unregister_netdev() in
> __dev_close_many routine if necessary and, doing so, we will end up causing
> an underflow in the qdma users atomic counters. Rely on networking subsystem
> to stop the device removing the airoha_eth module.
> 
> Fixes: 23020f0493270 ("net: airoha: Introduce ethernet support for EN7581 SoC")
> Signed-off-by: Lorenzo Bianconi <[email-masked]>
> ---
> Changes in v2:
> - Target net tree instead of net-next
> - Add missing Fixes tag and improve commit log.
> - Link to v1: https://lore.kernel.org/netdev/[email-masked]/

Thanks Lorenzo,

This seems much clearer.

Reviewed-by: Simon Horman <[email-masked]>