Subject: Re: [2/2] dt-bindings: net: micrel: KSZ8041RNLI supports LED mode

From: Jakub Kicinski <[email-masked]>
Date: Fri, 13 Mar 2026 19:01:07 -0700

This is an AI-generated review of your patch. The human sending this
email has considered the AI review valid, or at least plausible.

For local reproduction steps see https://netdev-ai.bots.linux.dev/ai-local.html
---
dt-bindings: net: micrel: KSZ8041RNLI supports LED mode

Micrel KSZ8041RNLI supports LED mode, just like KSZ8041. This fixes (a.o.)
the following "make dtbs_check" warning for the r8a7791-koelsch device tree.

> diff --git a/Documentation/devicetree/bindings/net/micrel.yaml b/Documentation/devicetree/bindings/net/micrel.yaml
> --- a/Documentation/devicetree/bindings/net/micrel.yaml
> +++ b/Documentation/devicetree/bindings/net/micrel.yaml
> @@ -54,6 +54,7 @@
>        KSZ8021: register 0x1f, bits 5..4
>        KSZ8031: register 0x1f, bits 5..4
>        KSZ8041: register 0x1e, bits 15..14
> +      KSZ8041RLNI: register 0x1e, bits 15..14
                  ^^^^
This isn't a bug, but there's a typo here. Should this be KSZ8041RNLI
instead of KSZ8041RLNI?

The chip is called KSZ8041RNLI in the commit subject and in the compatible
string definition:

>        KSZ8051: register 0x1f, bits 5..4
>        KSZ8081: register 0x1f, bits 5..4
>        KSZ8091: register 0x1f, bits 5..4

[ ... ]

> @@ -80,6 +81,7 @@
>              contains:
>                enum:
>                  - ethernet-phy-id0022.1510
> +                - ethernet-phy-id0022.1537
>                  - ethernet-phy-id0022.1555
>                  - ethernet-phy-id0022.1556
>                  - ethernet-phy-id0022.1560
-- 
pw-bot: cr