Subject: Re: [PATCH net-next] net: phy: mxl-gpy: add PHY-level statistics via ethtool

From: Jakub Kicinski <[email-masked]>
Date: Sat, 14 Mar 2026 10:48:00 -0700

On Fri, 13 Mar 2026 01:19:07 +0000 Daniel Golle wrote:
> Report PCS receive error counts for all supported GPY115x, GPY2xx and
> MxL862xx PHYs.
> 
> Accumulate the vendor-specific PHY_ERRCNT read-clear counter
> (SEL=RXERR) in .update_stats() and expose it as both IEEE 802.3
> SymbolErrorDuringCarrier and generic rx_errors via
> .get_phy_stats().

This does not apply. The code itself LGTM. One question - the 8b
counter seems kinda narrow. I wonder if we should read it periodically
so it doesn't overflow? Could be an overkill tho, IDK what's normal,
I defer to PHY maintainers..