From: Jakub Kicinski <kuba@kernel•org>
To: Haiyang Zhang <haiyangz@linux•microsoft.com>
Cc: linux-hyperv@vger•kernel.org, netdev@vger•kernel.org,
Andrew Lunn <andrew@lunn•ch>,
"David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Paolo Abeni <pabeni@redhat•com>, Simon Horman <horms@kernel•org>,
Donald Hunter <donald.hunter@gmail•com>,
Jonathan Corbet <corbet@lwn•net>,
Shuah Khan <skhan@linuxfoundation•org>,
"Kory Maincent (Dent Project)" <kory.maincent@bootlin•com>,
Gal Pressman <gal@nvidia•com>,
Oleksij Rempel <o.rempel@pengutronix•de>,
Vadim Fedorenko <vadim.fedorenko@linux•dev>,
linux-kernel@vger•kernel.org, linux-doc@vger•kernel.org,
haiyangz@microsoft•com, paulros@microsoft•com
Subject: Re: [PATCH net-next v5 1/3] net: ethtool: add ethtool COALESCE_RX_CQE_FRAMES/NSECS
Date: Mon, 16 Mar 2026 20:04:34 -0700 [thread overview]
Message-ID: <20260316200434.3a0b99ec@kernel.org> (raw)
In-Reply-To: <20260312193725.994833-2-haiyangz@linux.microsoft.com>
On Thu, 12 Mar 2026 12:37:04 -0700 Haiyang Zhang wrote:
> +Rx CQE coalescing allows multiple received packets to be coalesced into a single
> +Completion Queue Entry (CQE). ``ETHTOOL_A_COALESCE_RX_CQE_FRAMES`` describes the
> +maximum number of frames that can be coalesced into a CQE.
> +``ETHTOOL_A_COALESCE_RX_CQE_NSECS`` describes max time in nanoseconds after the
> +first packet arrival in a coalesced CQE to be sent.
Looks good overall, can we broaden the language a bit?
Replace "a single Completion Queue Entry (CQE)" with "a single
Completion Queue Entry (CQE) or descriptor write back"?
I'm assuming your devices don't coalesce CQE writes.
For non-RDMA devices the notion of CQE is a bit foreign but
descriptor write back coalescing serves similar purpose.
In either case host can't see the frame even if it's busy
polling.
So:
Rx CQE coalescing allows multiple received packets to be coalesced
into a single Completion Queue Entry (CQE) or descriptor writeback.
``ETHTOOL_A_COALESCE_RX_CQE_FRAMES`` describes the maximum number of
frames that can be coalesced into a CQE or writeback.
``ETHTOOL_A_COALESCE_RX_CQE_NSECS`` describes max time in nanoseconds
after the first packet arrival in a coalesced CQE to be sent.
next prev parent reply other threads:[~2026-03-17 3:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-12 19:37 [PATCH net-next v5 0/3] add ethtool COALESCE_RX_CQE_FRAMES/NSECS and use it in MANA driver Haiyang Zhang
2026-03-12 19:37 ` [PATCH net-next v5 1/3] net: ethtool: add ethtool COALESCE_RX_CQE_FRAMES/NSECS Haiyang Zhang
2026-03-17 3:04 ` Jakub Kicinski [this message]
2026-03-17 17:06 ` [EXTERNAL] " Haiyang Zhang
2026-03-12 19:37 ` [PATCH net-next v5 2/3] net: mana: Add support for RX CQE Coalescing Haiyang Zhang
2026-03-12 19:37 ` [PATCH net-next v5 3/3] net: mana: Add ethtool counters for RX CQEs in coalesced type Haiyang Zhang
2026-03-15 16:11 ` [PATCH net-next v5 0/3] add ethtool COALESCE_RX_CQE_FRAMES/NSECS and use it in MANA driver Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260316200434.3a0b99ec@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=andrew@lunn$(echo .)ch \
--cc=corbet@lwn$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=donald.hunter@gmail$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=gal@nvidia$(echo .)com \
--cc=haiyangz@linux$(echo .)microsoft.com \
--cc=haiyangz@microsoft$(echo .)com \
--cc=horms@kernel$(echo .)org \
--cc=kory.maincent@bootlin$(echo .)com \
--cc=linux-doc@vger$(echo .)kernel.org \
--cc=linux-hyperv@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=o.rempel@pengutronix$(echo .)de \
--cc=pabeni@redhat$(echo .)com \
--cc=paulros@microsoft$(echo .)com \
--cc=skhan@linuxfoundation$(echo .)org \
--cc=vadim.fedorenko@linux$(echo .)dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox