Subject: Re: [PATCH net-next] bonding: move utsrelease.h include out of bonding_priv.h

From: Jakub Kicinski <[email-masked]>
Date: Tue, 17 Mar 2026 18:37:56 -0700

On Mon, 16 Mar 2026 05:17:45 -0700 Breno Leitao wrote:
> +++ b/drivers/net/bonding/bond_procfs.c
> @@ -6,8 +6,11 @@
>  #include <net/netns/generic.h>
>  #include <net/bonding.h>
>  
> +#include <generated/utsrelease.h>
>  #include "bonding_priv.h"

Somewhat unfortunate placement, shouldnt it be the first include above
the linux/ ones? If we were going best-effort-alphabetically?

> +#define bond_version DRV_DESCRIPTION ": v" UTS_RELEASE "\n"
> +
>  static void *bond_info_seq_start(struct seq_file *seq, loff_t *pos)
>  	__acquires(RCU)
>  {
> diff --git a/drivers/net/bonding/bonding_priv.h b/drivers/net/bonding/bonding_priv.h
> index fef6288c6944f..f9b327b6a494a 100644
> --- a/drivers/net/bonding/bonding_priv.h
> +++ b/drivers/net/bonding/bonding_priv.h
> @@ -12,11 +12,7 @@
>  
>  #ifndef _BONDING_PRIV_H
>  #define _BONDING_PRIV_H
> -#include <generated/utsrelease.h>
> -
>  #define DRV_NAME	"bonding"
>  #define DRV_DESCRIPTION	"Ethernet Channel Bonding Driver"

I think this entire header can go, TBH?
DESCRIPTION is used only in main
And DRV_NAME can be replaced by KBUILD_MODNAME where it's used.

> -#define bond_version DRV_DESCRIPTION ": v" UTS_RELEASE "\n"
> -
>  #endif