Subject: Re: [PATCH net-next v7 10/10] net: ethtool: Introduce ethtool command to list ports

From: Jakub Kicinski <[email-masked]>
Date: Wed, 18 Mar 2026 15:00:20 -0700

On Wed, 18 Mar 2026 08:28:00 +0100 Maxime Chevallier wrote:
> >> +#include "common.h"
> >> +#include "bitset.h"
> >> +#include "netlink.h"  
> > 
> > alpha sort  
> 
> So that's not as easy as it looks, "bitset.h" is really barebones and
> needs definitions for stuff like ETH_GSTRING_LEN, but also all the
> u32/bool types, etc.
> 
> In all files in net/ethtool/*.c the local includes list isnt' properly
> sorted due to that.

That's not right, let's fix it. Headers should be self-sufficient.