Subject: Re: [net-next PATCH 3/4] octeontx2-af: npa: cn20k: Add debugfs for Halo

From: Simon Horman <[email-masked]>
Date: Wed, 18 Mar 2026 15:18:40 +0000

On Mon, Mar 16, 2026 at 06:27:38PM +0530, Subbaraya Sundeep wrote:

...

> diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_debugfs.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu_debugfs.c

...

> @@ -1204,6 +1210,20 @@ static void print_npa_pool_ctx(struct seq_file *m, struct npa_aq_enq_rsp *rsp)
>  		seq_printf(m, "W8: fc_msh_dst\t\t%d\n", pool->fc_msh_dst);
>  }
>  
> +static inline char *npa_ctype_str(int ctype)

Please don't use the inline keyword in C code unless there is a
demonstrable - usually performance - reason to do so.

Also, I wonder if the return type for this function should be const.

> +{
> +	switch (ctype) {
> +	case NPA_AQ_CTYPE_AURA:
> +		return "aura";
> +	case NPA_AQ_CTYPE_HALO:
> +		return "halo";
> +	case NPA_AQ_CTYPE_POOL:
> +		return "pool";
> +	default:
> +		return NULL;
> +	}
> +}
> +

...