From: Simon Horman <horms@kernel•org>
To: Erni Sri Satya Vennela <ernis@linux•microsoft.com>
Cc: kys@microsoft•com, haiyangz@microsoft•com, wei.liu@kernel•org,
decui@microsoft•com, longli@microsoft•com, andrew+netdev@lunn•ch,
davem@davemloft•net, edumazet@google•com, kuba@kernel•org,
pabeni@redhat•com, kotaranov@microsoft•com,
shradhagupta@linux•microsoft.com, shirazsaleem@microsoft•com,
dipayanroy@linux•microsoft.com, yury.norov@gmail•com,
kees@kernel•org, ssengar@linux•microsoft.com,
gargaditya@linux•microsoft.com, linux-hyperv@vger•kernel.org,
netdev@vger•kernel.org, linux-kernel@vger•kernel.org,
linux-rdma@vger•kernel.org
Subject: Re: [PATCH net-next v4] net: mana: Expose hardware diagnostic info via debugfs
Date: Fri, 20 Mar 2026 09:55:53 +0000 [thread overview]
Message-ID: <20260320095553.GD1753385@horms.kernel.org> (raw)
In-Reply-To: <20260319070926.1459515-1-ernis@linux.microsoft.com>
On Thu, Mar 19, 2026 at 12:09:13AM -0700, Erni Sri Satya Vennela wrote:
> Add debugfs entries to expose hardware configuration and diagnostic
> information that aids in debugging driver initialization and runtime
> operations without adding noise to dmesg.
>
> The debugfs directory creation and removal for each PCI device is
> integrated into mana_gd_setup() and mana_gd_cleanup_device()
> respectively, so that all callers (probe, remove, suspend, resume,
> shutdown) share a single code path.
>
> Device-level entries (under /sys/kernel/debug/mana/<slot>/):
> - num_msix_usable, max_num_queues: Max resources from hardware
> - gdma_protocol_ver, pf_cap_flags1: VF version negotiation results
> - num_vports, bm_hostmode: Device configuration
>
> Per-vPort entries (under /sys/kernel/debug/mana/<slot>/vportN/):
> - port_handle: Hardware vPort handle
> - max_sq, max_rq: Max queues from vPort config
> - indir_table_sz: Indirection table size
> - steer_rx, steer_rss, steer_update_tab, steer_cqe_coalescing:
> Last applied steering configuration parameters
>
> Signed-off-by: Erni Sri Satya Vennela <ernis@linux•microsoft.com>
> ---
> Changes in v4:
> * Rebase and fix conflicts.
> Changes in v3:
> * Rename mana_gd_cleanup to mana_gd_cleanup_device.
> * Add creation of debugfs entries in mana_gd_setup.
> * Add removal of debugfs entries in mana_gd_cleanup_device.
> * Remove bm_hostmode and num_vports from debugfs in mana_remove itself,
> because "ac" gets freed before debugfs_remove_recursive, to avoid
> Use-After-Free error.
> * Add "goto out:" in mana_cfg_vport_steering to avoid populating apc
> values when resp.hdr.status is not NULL.
Thanks for the updates.
Reviewed-by: Simon Horman <horms@kernel•org>
next prev parent reply other threads:[~2026-03-20 9:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-19 7:09 [PATCH net-next v4] net: mana: Expose hardware diagnostic info via debugfs Erni Sri Satya Vennela
2026-03-20 9:55 ` Simon Horman [this message]
2026-03-24 0:44 ` Jakub Kicinski
2026-03-24 16:20 ` Erni Sri Satya Vennela
2026-03-30 19:09 ` Erni Sri Satya Vennela
2026-03-30 22:23 ` Jakub Kicinski
2026-03-31 17:58 ` Erni Sri Satya Vennela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260320095553.GD1753385@horms.kernel.org \
--to=horms@kernel$(echo .)org \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=decui@microsoft$(echo .)com \
--cc=dipayanroy@linux$(echo .)microsoft.com \
--cc=edumazet@google$(echo .)com \
--cc=ernis@linux$(echo .)microsoft.com \
--cc=gargaditya@linux$(echo .)microsoft.com \
--cc=haiyangz@microsoft$(echo .)com \
--cc=kees@kernel$(echo .)org \
--cc=kotaranov@microsoft$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=kys@microsoft$(echo .)com \
--cc=linux-hyperv@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-rdma@vger$(echo .)kernel.org \
--cc=longli@microsoft$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=shirazsaleem@microsoft$(echo .)com \
--cc=shradhagupta@linux$(echo .)microsoft.com \
--cc=ssengar@linux$(echo .)microsoft.com \
--cc=wei.liu@kernel$(echo .)org \
--cc=yury.norov@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox