Subject: Re: [PATCH] ice: add missing reset of the mac header

From: Simon Horman <[email-masked]>
Date: Fri, 20 Mar 2026 18:04:54 +0000

On Fri, Mar 20, 2026 at 06:05:18AM +0100, Aleksandr Loktionov wrote:
> From: Katarzyna Wieczerzycka <[email-masked]>
> 
> By default skb->mac_header is not set, so reset prevents access to an
> invalid pointer.
> 
> Call skb_reset_mac_header() before accessing the mac header from skb.
> 
> Signed-off-by: Katarzyna Wieczerzycka <[email-masked]>
> Signed-off-by: Aleksandr Loktionov <[email-masked]>

Hi Katarzyna and Aleksandr,

I am curious:

Is this a bug? If so then it should probably have a fixes tag and
a bit more of a description around how this can happen.

If it is not a bug, then is this defensive? And if so, is it really necessary?

...