From: Masami Hiramatsu (Google) <mhiramat@kernel•org>
To: "Vineeth Pillai (Google)" <vineeth@bitbyteword•org>
Cc: "Steven Rostedt" <rostedt@goodmis•org>,
"Peter Zijlstra" <peterz@infradead•org>,
"Dmitry Ilvokhin" <d@ilvokhin•com>,
"Masami Hiramatsu" <mhiramat@kernel•org>,
"Mathieu Desnoyers" <mathieu.desnoyers@efficios•com>,
"Ingo Molnar" <mingo@redhat•com>, "Jens Axboe" <axboe@kernel•dk>,
io-uring@vger•kernel.org, "David S. Miller" <davem@davemloft•net>,
"Eric Dumazet" <edumazet@google•com>,
"Jakub Kicinski" <kuba@kernel•org>,
"Paolo Abeni" <pabeni@redhat•com>,
"Alexei Starovoitov" <ast@kernel•org>,
"Daniel Borkmann" <daniel@iogearbox•net>,
"Marcelo Ricardo Leitner" <marcelo.leitner@gmail•com>,
"Xin Long" <lucien.xin@gmail•com>,
"Jon Maloy" <jmaloy@redhat•com>,
"Aaron Conole" <aconole@redhat•com>,
"Eelco Chaudron" <echaudro@redhat•com>,
"Ilya Maximets" <i.maximets@ovn•org>,
netdev@vger•kernel.org, bpf@vger•kernel.org,
linux-sctp@vger•kernel.org,
tipc-discussion@lists•sourceforge.net, dev@openvswitch•org,
"Jiri Pirko" <jiri@resnulli•us>,
"Oded Gabbay" <ogabbay@kernel•org>,
"Koby Elbaz" <koby.elbaz@intel•com>,
dri-devel@lists•freedesktop.org,
"Rafael J. Wysocki" <rafael@kernel•org>,
"Viresh Kumar" <viresh.kumar@linaro•org>,
"Gautham R. Shenoy" <gautham.shenoy@amd•com>,
"Huang Rui" <ray.huang@amd•com>,
"Mario Limonciello" <mario.limonciello@amd•com>,
"Len Brown" <lenb@kernel•org>,
"Srinivas Pandruvada" <srinivas.pandruvada@linux•intel.com>,
linux-pm@vger•kernel.org,
"MyungJoo Ham" <myungjoo.ham@samsung•com>,
"Kyungmin Park" <kyungmin.park@samsung•com>,
"Chanwoo Choi" <cw00.choi@samsung•com>,
"Christian König" <christian.koenig@amd•com>,
"Sumit Semwal" <sumit.semwal@linaro•org>,
linaro-mm-sig@lists•linaro.org,
"Eddie James" <eajames@linux•ibm.com>,
"Andrew Jeffery" <andrew@codeconstruct•com.au>,
"Joel Stanley" <joel@jms•id.au>,
linux-fsi@lists•ozlabs.org, "David Airlie" <airlied@gmail•com>,
"Simona Vetter" <simona@ffwll•ch>,
"Alex Deucher" <alexander.deucher@amd•com>,
"Danilo Krummrich" <dakr@kernel•org>,
"Matthew Brost" <matthew.brost@intel•com>,
"Philipp Stanner" <phasta@kernel•org>,
"Harry Wentland" <harry.wentland@amd•com>,
"Leo Li" <sunpeng.li@amd•com>,
amd-gfx@lists•freedesktop.org, "Jiri Kosina" <jikos@kernel•org>,
"Benjamin Tissoires" <bentiss@kernel•org>,
linux-input@vger•kernel.org,
"Wolfram Sang" <wsa+renesas@sang-engineering•com>,
linux-i2c@vger•kernel.org, "Mark Brown" <broonie@kernel•org>,
"Michael Hennerich" <michael.hennerich@analog•com>,
"Nuno Sá" <nuno.sa@analog•com>,
linux-spi@vger•kernel.org,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership•com>,
"Martin K. Petersen" <martin.petersen@oracle•com>,
linux-scsi@vger•kernel.org, "Chris Mason" <clm@fb•com>,
"David Sterba" <dsterba@suse•com>,
linux-btrfs@vger•kernel.org,
"Thomas Gleixner" <tglx@linutronix•de>,
"Andrew Morton" <akpm@linux-foundation•org>,
"SeongJae Park" <sj@kernel•org>,
linux-mm@kvack•org, "Borislav Petkov" <bp@alien8•de>,
"Dave Hansen" <dave.hansen@linux•intel.com>,
x86@kernel•org, linux-trace-kernel@vger•kernel.org,
linux-kernel@vger•kernel.org
Subject: Re: [PATCH v2 01/19] tracepoint: Add trace_call__##name() API
Date: Thu, 26 Mar 2026 10:28:40 +0900 [thread overview]
Message-ID: <20260326102840.80a270ec818fea7e000aeef4@kernel.org> (raw)
In-Reply-To: <20260323160052.17528-2-vineeth@bitbyteword.org>
On Mon, 23 Mar 2026 12:00:20 -0400
"Vineeth Pillai (Google)" <vineeth@bitbyteword•org> wrote:
> Add trace_call__##name() as a companion to trace_##name(). When a
> caller already guards a tracepoint with an explicit enabled check:
>
> if (trace_foo_enabled() && cond)
> trace_foo(args);
>
> trace_foo() internally repeats the static_branch_unlikely() test, which
> the compiler cannot fold since static branches are patched binary
> instructions. This results in two static-branch evaluations for every
> guarded call site.
>
> trace_call__##name() calls __do_trace_##name() directly, skipping the
> redundant static-branch re-check. This avoids leaking the internal
> __do_trace_##name() symbol into call sites while still eliminating the
> double evaluation:
>
> if (trace_foo_enabled() && cond)
> trace_invoke_foo(args); /* calls __do_trace_foo() directly */
nit: trace_call_foo() instead of trace_invoke_foo()?
Anyway looks good to me.
Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel•org>
>
> Three locations are updated:
> - __DECLARE_TRACE: invoke form omits static_branch_unlikely, retains
> the LOCKDEP RCU-watching assertion.
> - __DECLARE_TRACE_SYSCALL: same, plus retains might_fault().
> - !TRACEPOINTS_ENABLED stub: empty no-op so callers compile cleanly
> when tracepoints are compiled out.
>
> Suggested-by: Steven Rostedt <rostedt@goodmis•org>
> Suggested-by: Peter Zijlstra <peterz@infradead•org>
> Signed-off-by: Vineeth Pillai (Google) <vineeth@bitbyteword•org>
> Assisted-by: Claude:claude-sonnet-4-6
> ---
> include/linux/tracepoint.h | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/include/linux/tracepoint.h b/include/linux/tracepoint.h
> index 22ca1c8b54f32..ed969705341f1 100644
> --- a/include/linux/tracepoint.h
> +++ b/include/linux/tracepoint.h
> @@ -294,6 +294,10 @@ static inline struct tracepoint *tracepoint_ptr_deref(tracepoint_ptr_t *p)
> WARN_ONCE(!rcu_is_watching(), \
> "RCU not watching for tracepoint"); \
> } \
> + } \
> + static inline void trace_call__##name(proto) \
> + { \
> + __do_trace_##name(args); \
> }
>
> #define __DECLARE_TRACE_SYSCALL(name, proto, args, data_proto) \
> @@ -313,6 +317,11 @@ static inline struct tracepoint *tracepoint_ptr_deref(tracepoint_ptr_t *p)
> WARN_ONCE(!rcu_is_watching(), \
> "RCU not watching for tracepoint"); \
> } \
> + } \
> + static inline void trace_call__##name(proto) \
> + { \
> + might_fault(); \
> + __do_trace_##name(args); \
> }
>
> /*
> @@ -398,6 +407,8 @@ static inline struct tracepoint *tracepoint_ptr_deref(tracepoint_ptr_t *p)
> #define __DECLARE_TRACE_COMMON(name, proto, args, data_proto) \
> static inline void trace_##name(proto) \
> { } \
> + static inline void trace_call__##name(proto) \
> + { } \
> static inline int \
> register_trace_##name(void (*probe)(data_proto), \
> void *data) \
> --
> 2.53.0
>
--
Masami Hiramatsu (Google) <mhiramat@kernel•org>
next prev parent reply other threads:[~2026-03-26 1:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-23 16:00 [PATCH v2 00/19] tracepoint: Avoid double static_branch evaluation at guarded call sites Vineeth Pillai (Google)
2026-03-23 16:00 ` [PATCH v2 01/19] tracepoint: Add trace_call__##name() API Vineeth Pillai (Google)
2026-03-26 1:28 ` Masami Hiramatsu [this message]
2026-03-23 16:00 ` [PATCH v2 04/19] net: Use trace_call__##name() at guarded tracepoint call sites Vineeth Pillai (Google)
2026-03-24 15:33 ` Aaron Conole
2026-03-24 15:37 ` Steven Rostedt
2026-03-23 16:00 ` [PATCH v2 16/19] net: devlink: " Vineeth Pillai (Google)
2026-03-24 14:28 ` [PATCH v2 00/19] tracepoint: Avoid double static_branch evaluation at guarded " Steven Rostedt
2026-04-18 23:04 ` Steven Rostedt
2026-04-19 13:14 ` Vineeth Remanan Pillai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260326102840.80a270ec818fea7e000aeef4@kernel.org \
--to=mhiramat@kernel$(echo .)org \
--cc=James.Bottomley@HansenPartnership$(echo .)com \
--cc=aconole@redhat$(echo .)com \
--cc=airlied@gmail$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=alexander.deucher@amd$(echo .)com \
--cc=amd-gfx@lists$(echo .)freedesktop.org \
--cc=andrew@codeconstruct$(echo .)com.au \
--cc=ast@kernel$(echo .)org \
--cc=axboe@kernel$(echo .)dk \
--cc=bentiss@kernel$(echo .)org \
--cc=bp@alien8$(echo .)de \
--cc=bpf@vger$(echo .)kernel.org \
--cc=broonie@kernel$(echo .)org \
--cc=christian.koenig@amd$(echo .)com \
--cc=clm@fb$(echo .)com \
--cc=cw00.choi@samsung$(echo .)com \
--cc=d@ilvokhin$(echo .)com \
--cc=dakr@kernel$(echo .)org \
--cc=daniel@iogearbox$(echo .)net \
--cc=dave.hansen@linux$(echo .)intel.com \
--cc=davem@davemloft$(echo .)net \
--cc=dev@openvswitch$(echo .)org \
--cc=dri-devel@lists$(echo .)freedesktop.org \
--cc=dsterba@suse$(echo .)com \
--cc=eajames@linux$(echo .)ibm.com \
--cc=echaudro@redhat$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=gautham.shenoy@amd$(echo .)com \
--cc=harry.wentland@amd$(echo .)com \
--cc=i.maximets@ovn$(echo .)org \
--cc=io-uring@vger$(echo .)kernel.org \
--cc=jikos@kernel$(echo .)org \
--cc=jiri@resnulli$(echo .)us \
--cc=jmaloy@redhat$(echo .)com \
--cc=joel@jms$(echo .)id.au \
--cc=koby.elbaz@intel$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=kyungmin.park@samsung$(echo .)com \
--cc=lenb@kernel$(echo .)org \
--cc=linaro-mm-sig@lists$(echo .)linaro.org \
--cc=linux-btrfs@vger$(echo .)kernel.org \
--cc=linux-fsi@lists$(echo .)ozlabs.org \
--cc=linux-i2c@vger$(echo .)kernel.org \
--cc=linux-input@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mm@kvack$(echo .)org \
--cc=linux-pm@vger$(echo .)kernel.org \
--cc=linux-scsi@vger$(echo .)kernel.org \
--cc=linux-sctp@vger$(echo .)kernel.org \
--cc=linux-spi@vger$(echo .)kernel.org \
--cc=linux-trace-kernel@vger$(echo .)kernel.org \
--cc=lucien.xin@gmail$(echo .)com \
--cc=marcelo.leitner@gmail$(echo .)com \
--cc=mario.limonciello@amd$(echo .)com \
--cc=martin.petersen@oracle$(echo .)com \
--cc=mathieu.desnoyers@efficios$(echo .)com \
--cc=matthew.brost@intel$(echo .)com \
--cc=michael.hennerich@analog$(echo .)com \
--cc=mingo@redhat$(echo .)com \
--cc=myungjoo.ham@samsung$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nuno.sa@analog$(echo .)com \
--cc=ogabbay@kernel$(echo .)org \
--cc=pabeni@redhat$(echo .)com \
--cc=peterz@infradead$(echo .)org \
--cc=phasta@kernel$(echo .)org \
--cc=rafael@kernel$(echo .)org \
--cc=ray.huang@amd$(echo .)com \
--cc=rostedt@goodmis$(echo .)org \
--cc=simona@ffwll$(echo .)ch \
--cc=sj@kernel$(echo .)org \
--cc=srinivas.pandruvada@linux$(echo .)intel.com \
--cc=sumit.semwal@linaro$(echo .)org \
--cc=sunpeng.li@amd$(echo .)com \
--cc=tglx@linutronix$(echo .)de \
--cc=tipc-discussion@lists$(echo .)sourceforge.net \
--cc=vineeth@bitbyteword$(echo .)org \
--cc=viresh.kumar@linaro$(echo .)org \
--cc=wsa+renesas@sang-engineering$(echo .)com \
--cc=x86@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox