From: Jakub Kicinski <kuba@kernel•org>
To: <mst@redhat•com>, <jasowang@redhat•com>
Cc: Di Zhu <zhud@hygon•cn>, <xuanzhuo@linux•alibaba.com>,
<eperezma@redhat•com>, <andrew+netdev@lunn•ch>,
<davem@davemloft•net>, <edumazet@google•com>, <pabeni@redhat•com>,
<willemb@google•com>, <netdev@vger•kernel.org>,
<virtualization@lists•linux.dev>, <lijing@hygon•cn>,
<yingzhiwei@hygon•cn>
Subject: Re: [PATCH net-next v4] virtio-net: enable NETIF_F_GRO_HW only if GRO-related offloads are supported
Date: Thu, 26 Mar 2026 20:03:46 -0700 [thread overview]
Message-ID: <20260326200346.438702a6@kernel.org> (raw)
In-Reply-To: <20260323041730.986351-1-zhud@hygon.cn>
On Mon, 23 Mar 2026 12:17:30 +0800 Di Zhu wrote:
> Negotiating VIRTIO_NET_F_CTRL_GUEST_OFFLOADS indicates the device
> allows control over offload support, but the offloads that can be
> controlled may have nothing to do with GRO (e.g., if neither GUEST_TSO4
> nor GUEST_TSO6 is supported).
>
> In such a setup, reporting NETIF_F_GRO_HW as available for the device
> is too optimistic and misleading to the user.
>
> Improve the situation by masking off NETIF_F_GRO_HW unless the device
> possesses actual GRO-related offload capabilities. Out of an abundance
> of caution, this does not change the current behaviour for hardware with
> just v6 or just v4 GRO: current interfaces do not allow distinguishing
> between v6/v4 GRO, so we can't expose them to userspace precisely.
Michael, Jason, does this patch look good now?
https://lore.kernel.org/all/20260323041730.986351-1-zhud@hygon.cn/
next prev parent reply other threads:[~2026-03-27 3:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-23 4:17 [PATCH net-next v4] virtio-net: enable NETIF_F_GRO_HW only if GRO-related offloads are supported Di Zhu
2026-03-27 3:03 ` Jakub Kicinski [this message]
2026-03-27 3:22 ` Jason Wang
2026-03-27 3:29 ` Jakub Kicinski
2026-03-27 3:22 ` Jason Wang
2026-03-27 3:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260326200346.438702a6@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=eperezma@redhat$(echo .)com \
--cc=jasowang@redhat$(echo .)com \
--cc=lijing@hygon$(echo .)cn \
--cc=mst@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=virtualization@lists$(echo .)linux.dev \
--cc=willemb@google$(echo .)com \
--cc=xuanzhuo@linux$(echo .)alibaba.com \
--cc=yingzhiwei@hygon$(echo .)cn \
--cc=zhud@hygon$(echo .)cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox