From: Jakub Kicinski <kuba@kernel•org>
To: jiawenwu@trustnetic•com
Cc: Jakub Kicinski <kuba@kernel•org>,
netdev@vger•kernel.org, mengyuanlou@net-swift•com,
andrew+netdev@lunn•ch, davem@davemloft•net, edumazet@google•com,
pabeni@redhat•com, richardcochran@gmail•com,
linux@armlinux•org.uk, horms@kernel•org,
michal.swiatkowski@linux•intel.com, jacob.e.keller@intel•com,
kees@kernel•org, joe@dama•to, larysa.zaremba@intel•com,
abdun.nihaal@gmail•com, leitao@debian•org
Subject: Re: [PATCH net-next v6 04/11] net: ngbe: implement libwx reset ops
Date: Mon, 30 Mar 2026 17:55:27 -0700 [thread overview]
Message-ID: <20260331005527.3459556-1-kuba@kernel.org> (raw)
In-Reply-To: <20260326021406.30444-5-jiawenwu@trustnetic.com>
This is an AI-generated review of your patch. The human sending this
email has considered the AI review valid, or at least plausible.
---
net: ngbe: implement libwx reset ops
This commit implements the wx->do_reset() callback for the ngbe driver.
It provides a routine to bring the device down and back up when a reset
is requested while the device is running.
> diff --git a/drivers/net/ethernet/wangxun/ngbe/ngbe_main.c b/drivers/net/ethernet/wangxun/ngbe/ngbe_main.c
> index 8c9d505721b17..50a13dcf4b3c8 100644
> --- a/drivers/net/ethernet/wangxun/ngbe/ngbe_main.c
> +++ b/drivers/net/ethernet/wangxun/ngbe/ngbe_main.c
[ ... ]
> @@ -579,6 +586,32 @@ int ngbe_setup_tc(struct net_device *dev, u8 tc)
> return 0;
> }
>
> +static void ngbe_reinit_locked(struct wx *wx)
> +{
> + int err = 0;
> +
> + netif_trans_update(wx->netdev);
> +
> + err = wx_set_state_reset(wx);
> + if (err) {
> + wx_err(wx, "wait device reset timeout\n");
> + return;
> + }
> +
> + ngbe_down(wx);
> + ngbe_up(wx);
> +
> + clear_bit(WX_STATE_RESETTING, wx->state);
> +}
Is it possible to use a standard kernel mutex here instead of a bit flag for
synchronization?
Looking at the underlying implementation of wx_set_state_reset(), it relies
on an open-coded polling loop:
static inline int wx_set_state_reset(struct wx *wx)
{
u8 timeout = 50;
while (test_and_set_bit(WX_STATE_RESETTING, wx->state)) {
timeout--;
if (!timeout)
return -EBUSY;
usleep_range(1000, 2000);
}
return 0;
}
Using a bit flag and a sleep-polling loop to guard a teardown and bringup
section acts as an ad-hoc lock. This approach bypasses standard kernel
synchronization guarantees and prevents lockdep from analyzing the lock
ordering.
Since this context is allowed to sleep, could this section be protected by
a standard mutex instead?
--
pw-bot: cr
next prev parent reply other threads:[~2026-03-31 0:55 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-26 2:13 [PATCH net-next v6 00/11] Wangxun improvement and new support Jiawen Wu
2026-03-26 2:13 ` [PATCH net-next v6 01/11] net: ngbe: remove netdev->ethtool->wol_enabled setting Jiawen Wu
2026-03-26 2:13 ` [PATCH net-next v6 02/11] net: ngbe: move the WOL functions to libwx Jiawen Wu
2026-03-26 2:13 ` [PATCH net-next v6 03/11] net: ngbe: remove redundant macros Jiawen Wu
2026-03-26 2:13 ` [PATCH net-next v6 04/11] net: ngbe: implement libwx reset ops Jiawen Wu
2026-03-31 0:55 ` Jakub Kicinski [this message]
2026-03-31 7:19 ` Jiawen Wu
2026-03-31 13:03 ` Andrew Lunn
2026-03-31 23:05 ` Jacob Keller
2026-03-26 2:14 ` [PATCH net-next v6 05/11] net: wangxun: move reusable PCI driver ops functions into libwx Jiawen Wu
2026-03-31 0:55 ` Jakub Kicinski
2026-03-26 2:14 ` [PATCH net-next v6 06/11] net: txgbe: add power management support Jiawen Wu
2026-03-31 0:55 ` Jakub Kicinski
2026-03-26 2:14 ` [PATCH net-next v6 07/11] net: wangxun: move ethtool_ops.set_channels into libwx Jiawen Wu
2026-03-26 2:14 ` [PATCH net-next v6 08/11] net: wangxun: delete service_timer before cancel service_work Jiawen Wu
2026-03-31 0:55 ` Jakub Kicinski
2026-03-26 2:14 ` [PATCH net-next v6 09/11] net: wangxun: add Tx timeout process Jiawen Wu
2026-03-31 0:55 ` Jakub Kicinski
2026-03-26 2:14 ` [PATCH net-next v6 10/11] net: wangxun: improve flow control setting Jiawen Wu
2026-03-31 0:55 ` Jakub Kicinski
2026-03-26 2:14 ` [PATCH net-next v6 11/11] net: wangxun: implement pci_error_handlers ops Jiawen Wu
2026-03-31 0:55 ` Jakub Kicinski
2026-04-21 14:33 ` Lukas Wunner
2026-03-31 0:54 ` [PATCH net-next v6 00/11] Wangxun improvement and new support Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260331005527.3459556-1-kuba@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=abdun.nihaal@gmail$(echo .)com \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=horms@kernel$(echo .)org \
--cc=jacob.e.keller@intel$(echo .)com \
--cc=jiawenwu@trustnetic$(echo .)com \
--cc=joe@dama$(echo .)to \
--cc=kees@kernel$(echo .)org \
--cc=larysa.zaremba@intel$(echo .)com \
--cc=leitao@debian$(echo .)org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=mengyuanlou@net-swift$(echo .)com \
--cc=michal.swiatkowski@linux$(echo .)intel.com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=richardcochran@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox