Subject: Re: [PATCH net-next] pppoe: update Kconfig URLs

From: Qingfang Deng <[email-masked]>
Date: Tue, 31 Mar 2026 15:54:04 +0800

Hi,

On Tue, 31 Mar 2026 08:21:40 +0200, Jaco Kroon wrote:
>
> On 2026/03/31 05:33, Qingfang Deng wrote:
> >
> > --- a/drivers/net/ppp/Kconfig
> > +++ b/drivers/net/ppp/Kconfig
> > @@ -122,11 +122,10 @@ config PPPOE
> >   	help
> >   	  Support for PPP over Ethernet.
> >   
> > -	  This driver requires the latest version of pppd from the CVS
> > -	  repository at cvs.samba.org.  Alternatively, see the
> > -	  RoaringPenguin package (<http://www.roaringpenguin.com/pppoe>)
> > -	  which contains instruction on how to use this driver (under
> > -	  the heading "Kernel mode PPPoE").
> > +	  This driver requires the latest version of pppd at
> > +	  <https://ppp.samba.org>.
> > +	  Alternatively, see the out-of-tree RP-PPPoE plugin at
> > +	  <https://dianne.skoll.ca/projects/rp-pppoe/>.
> 
> ppp now exclusively has the plugin code (originally from roaring penguin 
> I believe).  Latest version is no longer relevant, that plugin has been 
> available since at least a few versions back already (at least a decade, 
> probably closer to two).
>
> That same code has recently been dropped from rp-pppoe, which now 
> primarily focusses on pppoe-server, and relies on the plugin now part of 
> ppp package itself. rp-pppoe is only required if you're running a 
> pppoe-server, and I don't think rp-pppoe at this stage will function 
> without ppp.
> 
> Most people will never need rp-pppoe.

Thanks for the information.

I just checked pppd's changelog: version 2.4.2 or later has the PPPoE
plugin.

I can update the help message accordingly:

	  To work in client mode, pppd version 2.4.2 or later is
	  required. To work in server mode, the pppoe-server command
	  from the RP-PPPoE package is also required, available at
	  <https://dianne.skoll.ca/projects/rp-pppoe/>.

What do you think?