Subject: Re: [PATCH net-next 3/4] net: macb: Factor out the handling of non-hot IRQ events into a separate function

From: Jakub Kicinski <[email-masked]>
Date: Tue, 31 Mar 2026 19:54:31 -0700

On Sat, 28 Mar 2026 18:17:47 +0800 Kevin Hao wrote:
>  	struct macb_queue *queue = dev_id;
>  	struct macb *bp = queue->bp;
>  	struct net_device *dev = bp->dev;
> -	u32 status, ctrl;
> +	u32 status;
>  	bool isr_clear;

nit: please try to keep the variable declaration lines sorted longest to
shortest