Subject: Re: [net-next v8 01/10] net: tso: Introduce tso_dma_map and helpers

From: Jakub Kicinski <[email-masked]>
Date: Mon, 6 Apr 2026 18:16:38 -0700

On Thu,  2 Apr 2026 17:35:08 -0700 Joe Damato wrote:
> +/**
> + * tso_dma_map_complete - tear down mapping at completion time
> + * @dev: the device that owns the mapping
> + * @cstate: state saved by tso_dma_map_completion_save()
> + *
> + * Returns true if the IOVA path was used and the mapping has been
> + * destroyed. Returns false if the fallback per-region path was used
> + * and the driver must unmap via its normal completion path.
> + */
> +static inline bool
> +tso_dma_map_complete(struct device *dev,
> +		     struct tso_dma_map_completion_state *cstate)
> +{
> +	if (dma_use_iova(&cstate->iova_state)) {
> +		dma_iova_destroy(dev, &cstate->iova_state, cstate->total_len,
> +				 DMA_TO_DEVICE, 0);
> +		return true;
> +	}
> +
> +	return false;
> +}

kdoc says:

Warning: include/net/tso.h:120 No description found for return value of 'tso_dma_map_complete'

missing the crucial : character..
-- 
pw-bot: cr