From: Jakub Kicinski <kuba@kernel•org>
To: Yue Haibing <yuehaibing@huawei•com>
Cc: <davem@davemloft•net>, <dsahern@kernel•org>,
<edumazet@google•com>, <pabeni@redhat•com>, <horms@kernel•org>,
<netdev@vger•kernel.org>, <linux-kernel@vger•kernel.org>
Subject: Re: [PATCH net-next] ipv6: sit: remove redundant ret = 0 assignment
Date: Mon, 6 Apr 2026 18:43:13 -0700 [thread overview]
Message-ID: <20260406184313.5c446354@kernel.org> (raw)
In-Reply-To: <20260403084402.4105936-1-yuehaibing@huawei.com>
On Fri, 3 Apr 2026 16:44:02 +0800 Yue Haibing wrote:
> The variable ret is initialized to 0 when it is defined
> and is not modified before copy_to_user().
Makes more sense to remove the init during definition IMO.
next prev parent reply other threads:[~2026-04-07 1:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-03 8:44 [PATCH net-next] ipv6: sit: remove redundant ret = 0 assignment Yue Haibing
2026-04-06 14:35 ` Simon Horman
2026-04-07 1:43 ` Jakub Kicinski [this message]
2026-04-08 1:26 ` Yue Haibing
2026-04-30 0:49 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260406184313.5c446354@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=dsahern@kernel$(echo .)org \
--cc=edumazet@google$(echo .)com \
--cc=horms@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=yuehaibing@huawei$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox