Subject: Re: [PATCH net v4 1/2] flow_dissector: do not dissect PPPoE PFC frames

From: Simon Horman <[email-masked]>
Date: Tue, 14 Apr 2026 16:50:32 +0100

On Sat, Apr 11, 2026 at 11:56:30AM +0800, Qingfang Deng wrote:
> Hi,
> 
> On 4/11/2026 1:10 AM, Simon Horman wrote:
> > On Fri, Apr 10, 2026 at 11:36:20AM +0800, Qingfang Deng wrote:
> > > @@ -1361,7 +1376,7 @@ bool __skb_flow_dissect(const struct net *net,
> > >   			struct pppoe_hdr hdr;
> > >   			__be16 proto;
> > >   		} *hdr, _hdr;
> > > -		u16 ppp_proto;
> > > +		__be16 ppp_proto;
> > 
> > I'm unclear of the relationship between changing the type of ppp_proto
> > and the problem described in the patch description. And it
> > is creating a log of churn in this patch. I suggest dropping it.
> 
> The intention is to restore the original behavior before the blamed commit.
> If you find it too verbose for a fix, I can drop it and then repost that
> part later to net-next.

Thanks, I see you have posted v5, which I plan to review.
FTR: I think it is best to split the fix, for net, from
other changes for net-next.

...