From: Simon Horman <horms@kernel•org>
To: ernis@linux•microsoft.com
Cc: Simon Horman <horms@kernel•org>,
haiyangz@microsoft•com, davem@davemloft•net,
longli@microsoft•com, ssengar@linux•microsoft.com,
linux-kernel@vger•kernel.org, kuba@kernel•org,
kotaranov@microsoft•com, stephen@networkplumber•org,
andrew+netdev@lunn•ch, kys@microsoft•com, wei.liu@kernel•org,
shirazsaleem@microsoft•com, kees@kernel•org, pabeni@redhat•com,
linux-hyperv@vger•kernel.org, edumazet@google•com,
decui@microsoft•com, leon@kernel•org,
gargaditya@linux•microsoft.com, dipayanroy@linux•microsoft.com,
netdev@vger•kernel.org, shacharr@microsoft•com
Subject: Re: [PATCH net v3 4/5] net: mana: Don't overwrite port probe error with add_adev result
Date: Fri, 17 Apr 2026 15:10:14 +0100 [thread overview]
Message-ID: <20260417141014.218936-1-horms@kernel.org> (raw)
In-Reply-To: <20260415080944.732901-5-ernis@linux.microsoft.com>
This is an AI-generated review of your patch. The human sending this
email has considered the AI review valid, or at least plausible.
For local reproduction steps see https://netdev-ai.bots.linux.dev/ai-local.html
---
net: mana: Don't overwrite port probe error with add_adev result
In mana_probe(), if mana_probe_port() fails for any port, the error
is stored in 'err' and the loop breaks. However, the subsequent
unconditional 'err = add_adev(gd, "eth")' overwrites this error.
If add_adev() succeeds, mana_probe() returns success despite ports
being left in a partially initialized state (ac->ports[i] == NULL).
Only call add_adev() when there is no prior error, so the probe
correctly fails and triggers mana_remove() cleanup.
> In mana_probe(), if mana_probe_port() fails for any port, the error
> is stored in 'err' and the loop breaks. However, the subsequent
> unconditional 'err = add_adev(gd, "eth")' overwrites this error.
> If add_adev() succeeds, mana_probe() returns success despite ports
> being left in a partially initialized state (ac->ports[i] == NULL).
>
> Only call add_adev() when there is no prior error, so the probe
> correctly fails and triggers mana_remove() cleanup.
>
> Fixes: ced82fce77e9 ("net: mana: Probe rdma device in mana driver")
The existing Fixes: tag points to commit ced82fce77e9 ("net: mana: Probe
rdma device in mana driver"), but was the bug actually introduced there?
Looking at the commit history, commit a69839d4327d ("net: mana: Add support
for auxiliary device") added the unconditional 'err = add_adev(gd);' call
that overwrites the error from mana_probe_port(). Commit ced82fce77e9 only
modified the add_adev signature from add_adev(gd) to add_adev(gd, "eth")
but did not introduce the buggy pattern.
Should the Fixes: tag be:
Fixes: a69839d4327d ("net: mana: Add support for auxiliary device")
next prev parent reply other threads:[~2026-04-17 14:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-15 8:09 [PATCH net v3 0/5] net: mana: Fix probe/remove error path bugs Erni Sri Satya Vennela
2026-04-15 8:09 ` [PATCH net v3 1/5] net: mana: Init link_change_work before potential error paths in probe Erni Sri Satya Vennela
2026-04-17 14:08 ` Simon Horman
2026-04-15 8:09 ` [PATCH net v3 2/5] net: mana: Init gf_stats_work " Erni Sri Satya Vennela
2026-04-17 14:08 ` Simon Horman
2026-04-15 8:09 ` [PATCH net v3 3/5] net: mana: Guard mana_remove against double invocation Erni Sri Satya Vennela
2026-04-17 14:09 ` Simon Horman
2026-04-20 12:45 ` Erni Sri Satya Vennela
2026-04-15 8:09 ` [PATCH net v3 4/5] net: mana: Don't overwrite port probe error with add_adev result Erni Sri Satya Vennela
2026-04-17 14:10 ` Simon Horman [this message]
2026-04-20 12:45 ` Erni Sri Satya Vennela
2026-04-15 8:09 ` [PATCH net v3 5/5] net: mana: Fix EQ leak in mana_remove on NULL port Erni Sri Satya Vennela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260417141014.218936-1-horms@kernel.org \
--to=horms@kernel$(echo .)org \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=decui@microsoft$(echo .)com \
--cc=dipayanroy@linux$(echo .)microsoft.com \
--cc=edumazet@google$(echo .)com \
--cc=ernis@linux$(echo .)microsoft.com \
--cc=gargaditya@linux$(echo .)microsoft.com \
--cc=haiyangz@microsoft$(echo .)com \
--cc=kees@kernel$(echo .)org \
--cc=kotaranov@microsoft$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=kys@microsoft$(echo .)com \
--cc=leon@kernel$(echo .)org \
--cc=linux-hyperv@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=longli@microsoft$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=shacharr@microsoft$(echo .)com \
--cc=shirazsaleem@microsoft$(echo .)com \
--cc=ssengar@linux$(echo .)microsoft.com \
--cc=stephen@networkplumber$(echo .)org \
--cc=wei.liu@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox