From: Simon Horman <horms@kernel•org>
To: Petr Oros <poros@redhat•com>
Cc: netdev@vger•kernel.org, Tony Nguyen <anthony.l.nguyen@intel•com>,
Przemek Kitszel <przemyslaw.kitszel@intel•com>,
Andrew Lunn <andrew+netdev@lunn•ch>,
"David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>,
Jesse Brandeburg <jesse.brandeburg@intel•com>,
Mitch Williams <mitch.a.williams@intel•com>,
Aaron Brown <aaron.f.brown@intel•com>,
Przemyslaw Patynowski <przemyslawx.patynowski@intel•com>,
Jedrzej Jagielski <jedrzej.jagielski@intel•com>,
intel-wired-lan@lists•osuosl.org, linux-kernel@vger•kernel.org,
jacob.e.keller@intel•com
Subject: Re: [PATCH iwl-net v2 0/4] iavf: fix VLAN filter state machine races
Date: Tue, 21 Apr 2026 10:02:54 +0100 [thread overview]
Message-ID: <20260421090254.GW280379@horms.kernel.org> (raw)
In-Reply-To: <cover.1776426683.git.poros@redhat.com>
On Fri, Apr 17, 2026 at 04:29:41PM +0200, Petr Oros wrote:
> The iavf VLAN filter state machine has several design issues that lead
> to race conditions between userspace add/del calls and the watchdog
> task's virtchnl processing. Filters can get lost or leak HW resources,
> especially during interface down/up cycles and namespace moves.
...
Hi Petr,
Sashiko has a bit to say about this patch.
I'd appreciate it if you could look over that.
In particular, the feedback on patches 2 and 3 may warrant
some updates to this patchset, while I think 4 is more
in the realm of possible future work.
next prev parent reply other threads:[~2026-04-21 9:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-17 14:29 [PATCH iwl-net v2 0/4] iavf: fix VLAN filter state machine races Petr Oros
2026-04-17 14:29 ` [PATCH iwl-net v2 1/4] iavf: rename IAVF_VLAN_IS_NEW to IAVF_VLAN_ADDING Petr Oros
2026-04-17 14:29 ` [PATCH iwl-net v2 2/4] iavf: stop removing VLAN filters from PF on interface down Petr Oros
2026-04-17 14:29 ` [PATCH iwl-net v2 3/4] iavf: wait for PF confirmation before removing VLAN filters Petr Oros
2026-04-17 14:29 ` [PATCH iwl-net v2 4/4] iavf: add VIRTCHNL_OP_ADD_VLAN to success completion handler Petr Oros
2026-04-17 15:22 ` [PATCH iwl-net v2 0/4] iavf: fix VLAN filter state machine races Przemek Kitszel
2026-04-21 9:02 ` Simon Horman [this message]
2026-04-23 20:48 ` Jacob Keller
2026-04-28 10:53 ` Petr Oros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260421090254.GW280379@horms.kernel.org \
--to=horms@kernel$(echo .)org \
--cc=aaron.f.brown@intel$(echo .)com \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=anthony.l.nguyen@intel$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=intel-wired-lan@lists$(echo .)osuosl.org \
--cc=jacob.e.keller@intel$(echo .)com \
--cc=jedrzej.jagielski@intel$(echo .)com \
--cc=jesse.brandeburg@intel$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=mitch.a.williams@intel$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=poros@redhat$(echo .)com \
--cc=przemyslaw.kitszel@intel$(echo .)com \
--cc=przemyslawx.patynowski@intel$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox