Subject: Re: [PATCH net-next 3/6] pds_core: add PLDM firmware update support via devlink flash

From: Jakub Kicinski <[email-masked]>
Date: Thu, 30 Apr 2026 18:05:21 -0700

On Wed, 29 Apr 2026 08:28:19 +0000 Nikhil P. Rao wrote:
> +#define PDS_CORE_FW_COMPONENT_LIST_LEN	((PDS_PAGE_SIZE - \
> +		sizeof(struct pds_core_component_list_info)) / \
> +		sizeof(struct pds_core_fw_component_info))
> +
> +#if defined(__has_attribute) && !__has_attribute(__counted_by__)
> +#define __counted_by(member)
> +#endif

Please don't redefined kernel-level primitives.
It's a huge pain in the rear to deal with when indexing the code.

This patch also adds a bunch of kdoc warnings.

Last but not least Sashiko points out a number of bugs