Subject: Re: [PATCH net-next 12/15] bnxt_en: Support kTLS TX offload by implementing .tls_dev_add/del()

From: Jakub Kicinski <[email-masked]>
Date: Tue, 5 May 2026 17:58:21 -0700

On Mon,  4 May 2026 16:58:33 -0700 Michael Chan wrote:
> Add basic infrastructure to allocate and free kTLS context IDs (KIDs)
> to support kTLS TX offload.  To offload a connection in .tls_dev_add(),
> the first step is to allocate a KID.  After that the kTLS offload
> command is sent to the HW via MPC using the function
> bnxt_xmit_crypto_cmd() introduced in the last patch.
> 
> In .tls_dev_del(), we send the delete command to the HW using the
> same bnxt_xmit_crypto_cmd().  After that we free the KID, making it
> available for new offload.
> 
> bnxt_ktls_ops will be assigned to the netdev and the TLS features will
> be enabled in the next patch.

drivers/net/ethernet/broadcom/bnxt/bnxt_ktls.c:269:32: warning: unused variable 'bnxt_ktls_ops' [-Wunused-const-variable]
  269 | static const struct tlsdev_ops bnxt_ktls_ops = {
      |                                ^~~~~~~~~~~~~

Warning: drivers/net/ethernet/broadcom/bnxt/bnxt_ktls.c:24 No description found for return value of 'bnxt_alloc_ktls_info'
Warning: drivers/net/ethernet/broadcom/bnxt/bnxt_ktls.c:24 No description found for return value of 'bnxt_alloc_ktls_info'