From: Ido Schimmel <idosch@nvidia•com>
To: Jakub Kicinski <kuba@kernel•org>
Cc: Danielle Ratson <danieller@nvidia•com>,
netdev@vger•kernel.org, donald.hunter@gmail•com,
davem@davemloft•net, edumazet@google•com, pabeni@redhat•com,
horms@kernel•org, razor@blackwall•org, andrew+netdev@lunn•ch,
shuah@kernel•org, ast@fiberby•net, liuhangbin@gmail•com,
daniel@iogearbox•net, aroulin@nvidia•com, fmaurer@redhat•com,
sdf.kernel@gmail•com, sd@queasysnail•net, kees@kernel•org,
nickgarlis@gmail•com, amorenoz@redhat•com,
alasdair@mcwilliam•dev, johannes.wiesboeck@aisec•fraunhofer.de,
petrm@nvidia•com, linux-kernel@vger•kernel.org,
bridge@lists•linux.dev, linux-kselftest@vger•kernel.org
Subject: Re: [PATCH net-next 1/6] bridge: uapi: Add neigh_forward_grat netlink attributes
Date: Wed, 6 May 2026 10:03:34 +0300 [thread overview]
Message-ID: <20260506070334.GA617302@shredder> (raw)
In-Reply-To: <20260505190044.0608dfb1@kernel.org>
On Tue, May 05, 2026 at 07:00:44PM -0700, Jakub Kicinski wrote:
> On Sun, 3 May 2026 10:35:27 +0300 Danielle Ratson wrote:
> > --- a/Documentation/netlink/specs/rt-link.yaml
> > +++ b/Documentation/netlink/specs/rt-link.yaml
> > @@ -1700,6 +1700,9 @@ attribute-sets:
> > -
> > name: backup-nhid
> > type: u32
> > + -
> > + name: neigh-forward-grat
> > + type: flag
>
> I think this should be u8 ? neigh-vlan-suppress looks buggy too
I pointed this out during internal review, but assumed I am missing
something since almost all the attributes use flag when they are in fact
u8. We can fix neigh-forward-grat to use u8 in v2 and change the rest in
net. To be clear, I believe the following should be converted from flag
to u8:
mode, guard, protect, fast-leave, learning, unicast-flood, proxyarp,
learning-sync, proxyarp-wifi, mcast-flood, mcast-to-ucast, vlan-tunnel,
bcast-flood, neigh-suppress, isolated, mrp-ring-open, mrp-in-open,
locked, mab, neigh-vlan-suppress
> flag is a type without a payload, the presence of the attr is
> the entire information
>
> None of the AIs seem to catch this, I think you may have over-split
> this submission a little bit. This patch may have been better off
> squashed into patch 4 ?
Related: The AI also did not catch that the spec was missing (easy to
forget for rtnetlink). Do you think it's worth adding to review-prompts?
next prev parent reply other threads:[~2026-05-06 7:03 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-03 7:35 [PATCH net-next 0/6] bridge: Add selective forwarding of gratuitous neighbor announcements Danielle Ratson
2026-05-03 7:35 ` [PATCH net-next 1/6] bridge: uapi: Add neigh_forward_grat netlink attributes Danielle Ratson
2026-05-04 7:41 ` Nikolay Aleksandrov
2026-05-06 2:00 ` Jakub Kicinski
2026-05-06 7:03 ` Ido Schimmel [this message]
2026-05-06 8:31 ` Danielle Ratson
2026-05-06 22:05 ` Jakub Kicinski
2026-05-07 6:54 ` Ido Schimmel
2026-05-03 7:35 ` [PATCH net-next 2/6] bridge: Add internal flags for neigh_forward_grat Danielle Ratson
2026-05-04 7:41 ` Nikolay Aleksandrov
2026-05-03 7:35 ` [PATCH net-next 3/6] bridge: Add selective forwarding of gratuitous neighbor announcements Danielle Ratson
2026-05-04 7:41 ` Nikolay Aleksandrov
2026-05-03 7:35 ` [PATCH net-next 4/6] bridge: Add port-level netlink handling for neigh_forward_grat Danielle Ratson
2026-05-04 7:42 ` Nikolay Aleksandrov
2026-05-03 7:35 ` [PATCH net-next 5/6] bridge: Add per-VLAN " Danielle Ratson
2026-05-04 7:43 ` Nikolay Aleksandrov
2026-05-03 7:35 ` [PATCH net-next 6/6] selftests: net: Add tests for neigh_forward_grat option Danielle Ratson
2026-05-04 7:44 ` Nikolay Aleksandrov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260506070334.GA617302@shredder \
--to=idosch@nvidia$(echo .)com \
--cc=alasdair@mcwilliam$(echo .)dev \
--cc=amorenoz@redhat$(echo .)com \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=aroulin@nvidia$(echo .)com \
--cc=ast@fiberby$(echo .)net \
--cc=bridge@lists$(echo .)linux.dev \
--cc=daniel@iogearbox$(echo .)net \
--cc=danieller@nvidia$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=donald.hunter@gmail$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=fmaurer@redhat$(echo .)com \
--cc=horms@kernel$(echo .)org \
--cc=johannes.wiesboeck@aisec$(echo .)fraunhofer.de \
--cc=kees@kernel$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-kselftest@vger$(echo .)kernel.org \
--cc=liuhangbin@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nickgarlis@gmail$(echo .)com \
--cc=pabeni@redhat$(echo .)com \
--cc=petrm@nvidia$(echo .)com \
--cc=razor@blackwall$(echo .)org \
--cc=sd@queasysnail$(echo .)net \
--cc=sdf.kernel@gmail$(echo .)com \
--cc=shuah@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox