From: Jakub Kicinski <kuba@kernel•org>
To: Holger Brunck <holger.brunck@hitachienergy•com>
Cc: "netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"linuxppc-dev@lists•ozlabs.org" <linuxppc-dev@lists•ozlabs.org>,
"andrew+netdev@lunn•ch" <andrew+netdev@lunn•ch>,
"chleroy@kernel•org" <chleroy@kernel•org>,
"qiang.zhao@nxp•com" <qiang.zhao@nxp•com>,
"horms@kernel•org" <horms@kernel•org>
Subject: Re: [PATCH net] net: wan: fsl_ucc_hdlc: return NETDEV_TX_OK if skb was freed
Date: Wed, 6 May 2026 16:14:21 -0700 [thread overview]
Message-ID: <20260506161421.4e15d466@kernel.org> (raw)
In-Reply-To: <AM0PR06MB1039608A8965FE12520901515F73F2@AM0PR06MB10396.eurprd06.prod.outlook.com>
On Wed, 6 May 2026 09:35:00 +0000 Holger Brunck wrote:
> > On Mon, 4 May 2026 19:44:06 +0200 Holger Brunck wrote:
> > > If the skb was freed in the ucc_hdlc_tx function and the packet marked
> > > as dropped we need to return NETDEV_TX_OK. Otherwise the above layer
> > > will try to requeue an already freed skb.
> >
> > Is this really true? I thought negative returns mean drop.
>
> the API suggest to only use NETDEV_TX_OK or NETDEV_TX_BUSY as return value.
> I checked several drivers and they are usually returning NETDEV_TX_OK if an
> error occurred and the driver consumed the packet. But you are right
> dev_xmit_complete will also return true if the return code is smaller than zero
> and the packet is not requeued. Should I update the commit message or should
> the patch be dropped?
Drop the patch.
prev parent reply other threads:[~2026-05-06 23:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-04 17:44 [PATCH net] net: wan: fsl_ucc_hdlc: return NETDEV_TX_OK if skb was freed Holger Brunck
2026-05-06 1:22 ` Jakub Kicinski
2026-05-06 9:35 ` Holger Brunck
2026-05-06 23:14 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260506161421.4e15d466@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=chleroy@kernel$(echo .)org \
--cc=holger.brunck@hitachienergy$(echo .)com \
--cc=horms@kernel$(echo .)org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=qiang.zhao@nxp$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox