From: Jakub Kicinski <kuba@kernel•org>
To: Marc Kleine-Budde <mkl@pengutronix•de>
Cc: netdev@vger•kernel.org, davem@davemloft•net,
linux-can@vger•kernel.org, kernel@pengutronix•de,
Ciprian Marian Costea <ciprianmarian.costea@oss•nxp.com>
Subject: Re: [PATCH net 6/6] can: flexcan: disable all IRQ lines in flexcan_chip_interrupts_enable()
Date: Fri, 8 May 2026 15:11:59 -0700 [thread overview]
Message-ID: <20260508151159.71fa563a@kernel.org> (raw)
In-Reply-To: <20260507112321.439968-7-mkl@pengutronix.de>
On Thu, 7 May 2026 10:22:28 +0200 Marc Kleine-Budde wrote:
> flexcan_chip_interrupts_enable() disables only the primary IRQ line while
> writing to the IMASK and CTRL registers.
>
> On multi-IRQ platforms (S32G2, MCF5441X), the additional IRQ lines (boff,
> err, secondary-mb) remain active so their handlers can fire while
> registers are inconsistent.
>
> Disable all registered IRQ lines around the IMASK/CTRL writes. This
> also fixes the resume path, which calls this function.
Sashiko points out that the driver is requesting those IRQs with
IRQF_SHARED, I think you should also clear that flag if the QUIRK
is necessary.
Marc, sorry for the delay LMK if you prefer follow up or respin
next prev parent reply other threads:[~2026-05-08 22:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-07 8:22 [PATCH net 0/6] pull-request: can 2026-05-07 Marc Kleine-Budde
2026-05-07 8:22 ` [PATCH net 1/6] can: raw: add locking for raw flags bitfield Marc Kleine-Budde
2026-05-07 8:22 ` [PATCH net 2/6] can: bcm: prevent thrtimer UAF in rx path by checking RX_NO_AUTOTIMER Marc Kleine-Budde
2026-05-08 22:12 ` Jakub Kicinski
2026-05-13 13:59 ` Lee Jones
2026-05-13 14:17 ` Marc Kleine-Budde
2026-05-13 15:00 ` Lee Jones
2026-05-07 8:22 ` [PATCH net 3/6] can: j1939: fix wrong RX timeout for CTS hold messages Marc Kleine-Budde
2026-05-07 8:22 ` [PATCH net 4/6] can: j1939: fix lockless local-destination check Marc Kleine-Budde
2026-05-07 8:22 ` [PATCH net 5/6] can: peak: Modification of references to email accounts being deleted Marc Kleine-Budde
2026-05-07 8:22 ` [PATCH net 6/6] can: flexcan: disable all IRQ lines in flexcan_chip_interrupts_enable() Marc Kleine-Budde
2026-05-08 22:11 ` Jakub Kicinski [this message]
2026-05-13 14:17 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260508151159.71fa563a@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=ciprianmarian.costea@oss$(echo .)nxp.com \
--cc=davem@davemloft$(echo .)net \
--cc=kernel@pengutronix$(echo .)de \
--cc=linux-can@vger$(echo .)kernel.org \
--cc=mkl@pengutronix$(echo .)de \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox