Subject: Re: [PATCH net-next v2 2/5] ionic: Get "link_down_count" ext link stat from firmware

From: Jakub Kicinski <[email-masked]>
Date: Fri, 8 May 2026 15:54:12 -0700

On Tue, 5 May 2026 21:35:22 -0700 Eric Joyner wrote:
> The number of times that link has gone down at the port level is tracked
> by the firmware and sent to the driver via regular DMA writes to an
> instance of struct ionic_port_status in the driver's memory.
> 
> This statistic was never reported in favor of a driver-derived stat, but
> doing it in the driver was never necessary since firmware had been
> reporting it the whole time. Since it would be more accurate and true to
> the description of the statistic to get this count at the PHY level,
> replace the driver-calculated statistic with the firmware one and remove
> the driver-calculated one entirely.

missing le16_to_cpu() ?

drivers/net/ethernet/pensando/ionic/ionic_ethtool.c:120:41: warning: incorrect type in assignment (different base types)
drivers/net/ethernet/pensando/ionic/ionic_ethtool.c:120:41:    expected unsigned long long [usertype] link_down_events
drivers/net/ethernet/pensando/ionic/ionic_ethtool.c:120:41:    got restricted __le16 [usertype] link_down_count