Subject: Re: [PATCH ipsec-next v2] esp: Consolidate esp4 and esp6

From: David Laight <[email-masked]>
Date: Sun, 10 May 2026 12:20:15 +0100

On Wed, 6 May 2026 10:15:06 +0200
Steffen Klassert <[email-masked]> wrote:

> This patch merges common code of esp4.c and esp6.c into
> xfrm_esp.c. This almost halves the size of the ESP
> implementation for the price of three indirect calls
> on UDP/TCP encapsulation. No functional changes.

Merging into a new file make it very difficult to see the changes
(both now and in the future).

It might be better to merge the changes into either esp4.c or esp6.c
and then rename the file afterwards.

Since there are only two possibilities (ipv4 and ipv6) conditional
calls would be better than indirect ones.
But it is pretty impossible to see where that happens in the changes.

-- David