From: Jason Xing <kerneljasonxing@gmail•com>
To: davem@davemloft•net, edumazet@google•com, kuba@kernel•org,
pabeni@redhat•com, horms@kernel•org, willemb@google•com,
kuniyu@google•com, ast@kernel•org, daniel@iogearbox•net,
andrii@kernel•org, martin.lau@linux•dev, eddyz87@gmail•com,
memxor@gmail•com, song@kernel•org, yonghong.song@linux•dev,
jolsa@kernel•org, john.fastabend@gmail•com, sdf@fomichev•me
Cc: netdev@vger•kernel.org, bpf@vger•kernel.org,
Jason Xing <kernelxing@tencent•com>
Subject: [PATCH net-next 5/6] bpf: enable bpf timestamping rx in TCP layer
Date: Mon, 18 May 2026 16:23:43 +0800 [thread overview]
Message-ID: <20260518082344.96647-6-kerneljasonxing@gmail.com> (raw)
In-Reply-To: <20260518082344.96647-1-kerneljasonxing@gmail.com>
From: Jason Xing <kernelxing@tencent•com>
Add two if statements to accurately isolate bpf timestamping and so
timestamping. They can work respectively.
As to so_timestamping, only add a loose condition via report flags
to avoid duplicate strict checks that is done in tcp_recv_timestamp()
and performance impact. If the loose condition is hit,
tcp_recv_timestamp() is able to handle the exact case and doesn't
hamper the existing timestamping feature.
Make it work in TCP protocol.
Signed-off-by: Jason Xing <kernelxing@tencent•com>
---
net/ipv4/tcp.c | 14 ++++++++++++--
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c
index 21ece4c71612..64c69bb3578a 100644
--- a/net/ipv4/tcp.c
+++ b/net/ipv4/tcp.c
@@ -2949,8 +2949,18 @@ int tcp_recvmsg(struct sock *sk, struct msghdr *msg, size_t len, int flags)
release_sock(sk);
if ((cmsg_flags | msg->msg_get_inq) && ret >= 0) {
- if (cmsg_flags & TCP_CMSG_TS)
- tcp_recv_timestamp(msg, sk, &tss);
+ if (cmsg_flags & TCP_CMSG_TS) {
+ u32 tsflags = READ_ONCE(sk->sk_tsflags);
+
+ if (cgroup_bpf_enabled(CGROUP_SOCK_OPS) &&
+ SK_BPF_CB_FLAG_TEST(sk, SK_BPF_CB_RX_TIMESTAMPING))
+ bpf_skops_rx_timestamping(sk, &tss,
+ BPF_SOCK_OPS_TSTAMP_RCV_CB);
+ if (sock_flag(sk, SOCK_RCVTSTAMP) ||
+ tsflags & SOF_TIMESTAMPING_SOFTWARE ||
+ tsflags & SOF_TIMESTAMPING_RAW_HARDWARE)
+ tcp_recv_timestamp(msg, sk, &tss);
+ }
if ((cmsg_flags & TCP_CMSG_INQ) | msg->msg_get_inq) {
msg->msg_inq = tcp_inq_hint(sk);
if (cmsg_flags & TCP_CMSG_INQ)
--
2.43.7
next prev parent reply other threads:[~2026-05-18 8:24 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-18 8:23 [PATCH net-next 0/6] bpf-timetamp: support rx side Jason Xing
2026-05-18 8:23 ` [PATCH net-next 1/6] bpf: Add bpf_ktime_get_real_ns() kfunc Jason Xing
2026-05-18 11:57 ` Jesper Dangaard Brouer
2026-05-18 12:35 ` Jason Xing
2026-05-18 8:23 ` [PATCH net-next 2/6] net: export sock_disable_timestamp() declaration Jason Xing
2026-05-18 8:23 ` [PATCH net-next 3/6] bpf: support bpf_setsockopt for bpf timestamping rx feature Jason Xing
2026-05-18 8:23 ` [PATCH net-next 4/6] bpf: add BPF_SOCK_OPS_TSTAMP_RCV_CB callback Jason Xing
2026-05-18 8:23 ` Jason Xing [this message]
2026-05-18 13:01 ` [PATCH net-next 5/6] bpf: enable bpf timestamping rx in TCP layer Jesper Dangaard Brouer
2026-05-18 13:53 ` Jason Xing
2026-05-18 16:40 ` Jesper Dangaard Brouer
2026-05-18 23:16 ` Jason Xing
2026-05-18 23:24 ` Jason Xing
2026-05-19 9:57 ` Toke Høiland-Jørgensen
2026-06-03 11:07 ` Toke Høiland-Jørgensen
2026-05-18 15:34 ` Stanislav Fomichev
2026-05-18 23:56 ` Jason Xing
2026-05-18 8:23 ` [PATCH net-next 6/6] selftests/bpf: Add RX latency tests for bpf timestamping Jason Xing
2026-05-18 11:46 ` [PATCH net-next 0/6] bpf-timetamp: support rx side Jesper Dangaard Brouer
2026-05-18 12:32 ` Jason Xing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260518082344.96647-6-kerneljasonxing@gmail.com \
--to=kerneljasonxing@gmail$(echo .)com \
--cc=andrii@kernel$(echo .)org \
--cc=ast@kernel$(echo .)org \
--cc=bpf@vger$(echo .)kernel.org \
--cc=daniel@iogearbox$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=eddyz87@gmail$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=horms@kernel$(echo .)org \
--cc=john.fastabend@gmail$(echo .)com \
--cc=jolsa@kernel$(echo .)org \
--cc=kernelxing@tencent$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=kuniyu@google$(echo .)com \
--cc=martin.lau@linux$(echo .)dev \
--cc=memxor@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=sdf@fomichev$(echo .)me \
--cc=song@kernel$(echo .)org \
--cc=willemb@google$(echo .)com \
--cc=yonghong.song@linux$(echo .)dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox