Subject: Re: [PATCH net 0/2] net: shaper: fix VALID confusion even more

From: Jakub Kicinski <[email-masked]>
Date: Wed, 20 May 2026 16:34:00 -0700

On Wed, 20 May 2026 20:54:28 +0100 Simon Horman wrote:
> On Fri, May 15, 2026 at 03:13:23PM -0700, Jakub Kicinski wrote:
> > Sashiko reported another pre-exising issue in the previous
> > batch of fixes:
> > https://sashiko.dev/#/patchset/[email-masked]
> > 
> > Turns out I over-esitmated the guarantees of the XArray flags.
> > Stop using them completely.
> 
> Sashiko suggests updating the wording of the VALID flag
> comment in net_shaper_pre_insert as part of the second patch.
> But, TBH, I don't feel strongly about that.

It's very picky about these comments.
IMHO the word "mark" is not reserved to exclusively mean xa_mark
in case no xa_mark is used by the code any more.

> For the series:
> Reviewed-by: Simon Horman <[email-masked]>

Thanks!