Subject: Re: [PATCH net-next v8 3/3] gve: implement PTP gettimex64

From: David Laight <[email-masked]>
Date: Thu, 21 May 2026 11:08:04 +0100

On Wed, 20 May 2026 23:08:42 +0200
Thomas Gleixner <[email-masked]> wrote:

> On Thu, May 14 2026 at 22:58, Harshitha Ramamurthy wrote:
...
> > +	do {
> > +		*pre_cycles = get_cycles();  
> 
> This is a completely non-sensical hack. Why do you need get_cycles()
> here, which is a horrible and ill-defined interface that others are
> trying to get rid of?

ISTR that it has always returned 0 on some architectures.

-- David