Subject: Re: [PATCH net v2 2/4] net: netlink: don't set nsid on local notifications

From: Jiri Benc <[email-masked]>
Date: Thu, 21 May 2026 16:00:36 +0200

On Thu, 21 May 2026 14:36:12 +0200, Nicolas Dichtel wrote:
> I still don't think that this is the right "fix". The app is broken. Even after
> this patch, the bug could be easily triggered again by a third party.
> There is nothing wrong with assigning a self-nsid. It would be a lot more robust
> for the app to assign itself a self-nsid when it starts.

On the other hand, does the patch break anything in practice (as
opposed to in theory)? It makes live of several apps simpler, which is
not a bad goal.

The only scenario where this would introduce incompatible behavior is
an app that self-assigns a self-nsid and expects to see it. That looks
quite stretched, doesn't it?

Not that I have a strong opinion about this, though.

 Jiri