Subject: Re: [PATCH v15 net-next 10/11] net/nebula-matrix: add common/ctrl dev init/reinit operation

From: Jakub Kicinski <[email-masked]>
Date: Fri, 22 May 2026 10:16:38 -0700

On Wed, 20 May 2026 11:29:42 +0800 illusion.wang wrote:
> Common Device Setup: nbl_dev_setup_common_dev configures mailbox queues,
> registers cleanup tasks, and MSI-X interrupt counter initialization.
> Control Device Setup (optional): nbl_dev_setup_ctrl_dev initializes
> the chip and configures all channel queues.

drivers/net/ethernet/nebula-matrix/nbl/nbl_core/nbl_dev.c:97:21: warning: result of comparison of constant 4294967295 with expression of type 'u16' (aka 'unsigned short') is always false [-Wtautological-constant-out-of-range-compare]
   97 |         if (common->vsi_id == U32_MAX) {
      |             ~~~~~~~~~~~~~~ ^  ~~~~~~~