Subject: Re: [PATCH] net: sfp: add quirk for OEM 2.5G optical modules

From: Jakub Kicinski <[email-masked]>
Date: Fri, 22 May 2026 17:14:33 -0700

On Wed, 20 May 2026 23:16:29 +0800 weixiansen574 wrote:
> Signed-off-by: weixiansen574 <[email-masked]>

A more official looking name is required.
Unicode characters are accepted FWIW, doesn't have to be westernized.

> diff --git a/drivers/net/phy/sfp.c b/drivers/net/phy/sfp.c
> index bd970f753..6f3213793 100644
> --- a/drivers/net/phy/sfp.c
> +++ b/drivers/net/phy/sfp.c
> @@ -583,6 +583,8 @@ static const struct sfp_quirk sfp_quirks[] = {
>  	SFP_QUIRK_S("OEM", "SFP-2.5G-T", sfp_quirk_oem_2_5g),
>  	SFP_QUIRK_S("OEM", "SFP-2.5G-BX10-D", sfp_quirk_2500basex),
>  	SFP_QUIRK_S("OEM", "SFP-2.5G-BX10-U", sfp_quirk_2500basex),
> +	SFP_QUIRK_S("OEM", "SFP-2.5G-LH20-A", sfp_quirk_2500basex),
> +	SFP_QUIRK_S("OEM", "SFP-2.5G-LH03-B", sfp_quirk_2500basex),

This list looks sorted, and I'd think LH03-B is before LH20-A 
because of the number?
-- 
pw-bot: cr