From: Jakub Kicinski <kuba@kernel•org>
To: Oscar Maes <oscmaes92@gmail•com>
Cc: netdev@vger•kernel.org, edumazet@google•com, pabeni@redhat•com
Subject: Re: [PATCH net-next v2 1/2] pcnet32: stop holding device spin lock during napi_complete_done
Date: Mon, 25 May 2026 08:46:02 -0700 [thread overview]
Message-ID: <20260525084602.685e450e@kernel.org> (raw)
In-Reply-To: <20260525125437.4061-2-oscmaes92@gmail.com>
On Mon, 25 May 2026 14:54:36 +0200 Oscar Maes wrote:
> napi_complete_done may call gro_flush_normal (though not currently, as GRO
> is unsupported at the moment), which may result in packet TX. This will
> eventually result in calling pcnet32_start_xmit - resulting in a deadlock
> while trying to re-acquire the already locked spin lock.
Looks like a legit bug fix, please add a Fixes tag and repost for net
(rather than net-next)
next prev parent reply other threads:[~2026-05-25 15:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-25 12:54 [PATCH net-next v2 0/2] pcnet32: switch to napi_alloc_skb() and napi_gro_receive() Oscar Maes
2026-05-25 12:54 ` [PATCH net-next v2 1/2] pcnet32: stop holding device spin lock during napi_complete_done Oscar Maes
2026-05-25 13:53 ` Andrew Lunn
2026-05-25 15:46 ` Jakub Kicinski [this message]
2026-05-25 12:54 ` [PATCH net-next v2 2/2] pcnet32: switch to napi_alloc_skb() and napi_gro_receive() Oscar Maes
2026-05-25 15:45 ` Jakub Kicinski
2026-05-28 14:28 ` Oscar Maes
2026-05-28 15:07 ` Jakub Kicinski
2026-05-28 17:05 ` Oscar Maes
2026-05-28 19:12 ` Jakub Kicinski
2026-05-31 16:51 ` Oscar Maes
2026-05-31 20:09 ` Andrew Lunn
2026-06-02 16:37 ` Oscar Maes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260525084602.685e450e@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=edumazet@google$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=oscmaes92@gmail$(echo .)com \
--cc=pabeni@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox