From: Christoph Hellwig <hch@lst•de>
To: "Vlastimil Babka (SUSE)" <vbabka@kernel•org>
Cc: Christoph Hellwig <hch@lst•de>, Harry Yoo <harry@kernel•org>,
Andrew Morton <akpm@linux-foundation•org>,
Hao Li <hao.li@linux•dev>, Christoph Lameter <cl@gentwo•org>,
David Rientjes <rientjes@google•com>,
Roman Gushchin <roman.gushchin@linux•dev>,
Jesper Dangaard Brouer <hawk@kernel•org>,
linux-arm-msm@vger•kernel.org, dri-devel@lists•freedesktop.org,
freedreno@lists•freedesktop.org, linux-kernel@vger•kernel.org,
linux-mm@kvack•org, io-uring@vger•kernel.org,
kasan-dev@googlegroups•com, bpf@vger•kernel.org,
netdev@vger•kernel.org
Subject: Re: improve the kmem_cache_alloc_bulk API
Date: Wed, 27 May 2026 14:21:48 +0200 [thread overview]
Message-ID: <20260527122148.GA6838@lst.de> (raw)
In-Reply-To: <ee817070-cc7a-40d5-92a4-2bd8e9e65fbe@kernel.org>
On Wed, May 27, 2026 at 11:11:31AM +0200, Vlastimil Babka (SUSE) wrote:
> > value convention. Fix that and add documentation.
> >
> > Note that the few comments explaining it mention that the gfp flags
> > must allow "spinning". That's not really a term used in the memory
> > allocator, is this supposed to mean "block" or "sleep"?
>
> Page allocator now has alloc_pages_nolock() for when no spinning is
> possible, and it uses ALLOC_TRYLOCK internally.
>
> Slab has kmalloc_nolock() relying on that when it needs new pages.
The comment long predates that, and it isn't expressed using gfp flags,
but by requiring separate functions so I somehow doubt that was meant.
But I could also not see why it would not support GFP_ATOMIC /
GFP_NOWAIT allocation, so I might just be confused.
next prev parent reply other threads:[~2026-05-27 12:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-27 7:02 improve the kmem_cache_alloc_bulk API Christoph Hellwig
2026-05-27 7:02 ` [PATCH] mm/slab: improve kmem_cache_alloc_bulk Christoph Hellwig
2026-05-27 7:53 ` bot+bpf-ci
2026-05-27 8:51 ` Jesper Dangaard Brouer
2026-05-27 13:56 ` Alexander Lobakin
2026-05-27 14:07 ` Christoph Hellwig
2026-05-27 9:38 ` Vlastimil Babka (SUSE)
2026-05-27 12:20 ` Christoph Hellwig
2026-05-28 8:58 ` kernel test robot
2026-05-27 9:11 ` improve the kmem_cache_alloc_bulk API Vlastimil Babka (SUSE)
2026-05-27 12:21 ` Christoph Hellwig [this message]
2026-05-27 14:07 ` Vlastimil Babka (SUSE)
2026-05-28 9:05 ` Christoph Hellwig
2026-05-28 9:16 ` Vlastimil Babka (SUSE)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260527122148.GA6838@lst.de \
--to=hch@lst$(echo .)de \
--cc=akpm@linux-foundation$(echo .)org \
--cc=bpf@vger$(echo .)kernel.org \
--cc=cl@gentwo$(echo .)org \
--cc=dri-devel@lists$(echo .)freedesktop.org \
--cc=freedreno@lists$(echo .)freedesktop.org \
--cc=hao.li@linux$(echo .)dev \
--cc=harry@kernel$(echo .)org \
--cc=hawk@kernel$(echo .)org \
--cc=io-uring@vger$(echo .)kernel.org \
--cc=kasan-dev@googlegroups$(echo .)com \
--cc=linux-arm-msm@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mm@kvack$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=rientjes@google$(echo .)com \
--cc=roman.gushchin@linux$(echo .)dev \
--cc=vbabka@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox